Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: update npm packages to latest versions #28000

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Gutenberg: update npm packages to latest versions #28000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8cbd032
Update Gutenberg packages to latest versions
vindl Oct 24, 2018
c7aa2ba
Bump package versions
vindl Oct 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/gutenberg/editor/controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ function registerDataPlugins( userId ) {
const storageKey = 'WP_DATA_USER_' + userId;

use( plugins.persistence, { storageKey: storageKey } );
use( plugins.asyncGenerator );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been removed from the latest version of @wordpress/data package: https://github.com/WordPress/gutenberg/blob/master/packages/data/CHANGELOG.md#300-2018-10-29

use( plugins.controls );
}

Expand Down
4 changes: 0 additions & 4 deletions client/gutenberg/editor/edit-post/components/header/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import {
} from '@wordpress/editor';
import { withDispatch, withSelect } from '@wordpress/data';
import { compose } from '@wordpress/compose';
import { DotTip } from '@wordpress/nux';

/**
* Internal dependencies
Expand Down Expand Up @@ -58,9 +57,6 @@ function Header( {
isToggled={ isEditorSidebarOpened }
aria-expanded={ isEditorSidebarOpened }
>
<DotTip id="core/editor.settings">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing the editor to break, so I'm removing it since this is the only usage of DotTip in edit post, and we don't want to use the guided tour anyway. I'm suspecting its related to some specific error with @wordpress/nux package and not to our integration.

{ __( 'You’ll find more settings for your page and blocks in the sidebar. Click ‘Settings’ to open it.' ) }
</DotTip>
</IconButton>
<PinnedPlugins.Slot />
<MoreMenu />
Expand Down
Loading