Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gutenberg: Disallow Tiled Gallery to be edited as HTML #29234

Merged
merged 1 commit into from Dec 7, 2018
Merged

Gutenberg: Disallow Tiled Gallery to be edited as HTML #29234

merged 1 commit into from Dec 7, 2018

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Dec 7, 2018

Changes proposed in this Pull Request

  • Disallow the Tiled Gallery block to be edited as HTML

Testing instructions

  • Spin up a new JN site with this branch: gutenpack-jn.
  • Connect the site and activate the recommended features.
  • Make sure beta blocks are enabled from /wp-admin/options-general.php?page=companion_settings.
  • Start writing a post.
  • Insert a Tiled Gallery block.
  • Click the three dots of the block.
  • Verify the "Edit as HTML" option no longer appears for the Tiled Gallery block.

Part of #29193.

@tyxla tyxla added [Type] Enhancement Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Dec 7, 2018
@tyxla tyxla self-assigned this Dec 7, 2018
@tyxla tyxla requested review from a team December 7, 2018 14:12
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/gutenberg-tiled-gallery-disable-html-edit

@tyxla tyxla mentioned this pull request Dec 7, 2018
Closed
simison
simison approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worrrrksss 👍 Thanks!

@tyxla tyxla added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 7, 2018
@tyxla tyxla merged commit 3e5aae4 into master Dec 7, 2018
@tyxla tyxla deleted the update/gutenberg-tiled-gallery-disable-html-edit branch December 7, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simison simison simison approved these changes

Assignees

@tyxla tyxla

Labels
[Block] Tiled Gallery [Goal] Gutenberg Working towards full integration with Gutenberg Jetpack [Type] Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tyxla @matticbot @simison