Private by default launch flow

[niranjan-uma-shankar]

Changes proposed in this Pull Request

• This PR implements the Private by default launch flow.
• The following happens when a user clicks the launch button on a private site:
  • If the site does not have a domain and/or a plan, we will take them through a site-launch flow.
    This flow will show the domain step and the plan step before taking them to the preview page with a
    successful launch banner:
  • If the site has both a domain and a plan, then the user is directly taken to the Preview page with a launch banner celebrating the success.

Testing instructions

Please apply D23389-code and follow the testing instructions given there.

Scenario-1 - Launch a site that does not have either a domain or a plan

1. Create a site on the Free plan without a domain (except the default *.wordpress.com domain)
2. Clicking Launch Site should go through the launch flow, showing both the domain and plan steps.
   There are a few scenarios that can be tested here:
   • Add both a domain and a plan to your cart so that you're taken to the checkout page. At this point, cancelling the purchase (by navigating away from checkout either by clicking the Trash icon in the cart on the left menu, or just closing the browser tab) should still launch the site. Check back in Preview that you no longer see the Launch Site button.
   • After adding both a domain and plan to your cart, make the purchase at the Checkout page. You should be redirected to the Site preview page with a success banner message.
   • You should be allowed to skip both the Domain purchase (by clicking Skip Purchase in the domain step) and Plan purchase (by clicking the Keep this Plan button in the plan step). You will then be directly taken to the Preview page with success banner (no checkout page)

Scenario-2 - Launch a site that does not have a domain but has a plan

1. Create a site with a paid plan but don't purchase a domain.
2. Clicking Launch Site should go through the launch flow, showing only the domain step. Test both with purchasing a domain and skipping Purchase - in both cases, it should take you to the Preview page with Success banner.

Scenario-3 - Launch a site that has a domain but does not have a plan

1. Create a site with a domain but no plan (for this you need to first create a site on a paid plan, purchase a domain, and then cancel the Plan purchase while retaining the domain).
2. Clicking Launch Site should go through the launch flow, showing only the plan step. Test both with purchasing a plan and skipping Purchase - in both cases, it should take you to the Preview page with Success banner.

Scenario-4 - Launch a site that has both a domain and a plan

1. Create a site on a paid plan with a domain
2. Launch the site, it should directly take you to the preview page (without going through the launch flow) and show a success banner.

Other tests

1. Test signup works correctly via the main and onboarding flows.
2. Test Add a new site option works correctly.
3. Test the subdomain flow works correctly. This is being used in .blog landing pages (photo.blog, food.blog etc). /start/subdomain?vertical=a8c.8 should show the default recommendation on the domain step to be a *.food.blog.

[matticbot]

Test live: https://calypso.live/?branch=add/private-by-default-launch-flow

[niranjan-uma-shankar]

Ooops... I did something while rebase that closed this PR. Re-opening.

[scruffian]

I made some changes to the cart which mean you no longer to supply the site Id - you can just use the site slug. That might simplify this code a bit...

[scruffian]

I think we have several different ways of adding things to the cart. There's one for domains and one for plans. It would be good if they both used the same code.

[niranjan-uma-shankar]

Please check 829ce5d. I've consolidated the common parts of the code in processItemCart(). I still had to retain addPlanToCart() and addDomainToCart() as separate functions because they provide different dependencies. Does it align with your suggestion or am I missing something?

[scruffian]

This is looking like it's heading in the right direction, great job :)

[niranjan-uma-shankar]

There are a few places where the destination is not respected.

1. On the checkout page, if you click the Trash icon on the cart in the left menu, you will be taken to the Upgrades page
2. If you go through the launch flow on a site that has a plan but without a domain, then the checkout page will take you to /thank-you/{siteSlug}/{receiptId}
3. If you purchase a domain or plan in the launch flow, then you'll be taken to Calypso preview /view/{siteSlug} instead of to https://{siteSlug}

At least some of them are due to the destination not being respected, and could get fixed with the work happening in #29136

[fditrapani]

Thanks for all this work @niranjan-uma-shankar and @scruffian. It tested well with a free plan, paid plan plus subdomain, and paid plan plus a domain. Here are a couple notes:

• It would be good to get a video/animated gif walkthrough of the flow as part of the description of this PR. It took me some time to get this all running on my machine.
• Clicking on the Launch button opens in a new tab feels disorienting to me. I think it would work better in the same tab.

These items can most likely be addressed in separate PRs:

• Domains screen: I like the suggestions there but it's not super clear right off the bat that they are suggestions.
• Domains: The skip option isn't super obvious because it's bundled in with the other choices.
• Domains: If I search and don't like the options, it's not clear to me that I have to clear the search to see the skip option again.
• Domains: The "Skip purchase" call to action doesn't seem right because we're asking folks to purchase a plan and not a domain.
• Plans: The "upgrade" call to action doesn't quite seem right — I do like the "Keep this plan" one though.

cc @danhauk

[niranjan-uma-shankar]

The success launch banner(shown after launch) and the private site banner(before launch) both have the same icon. Maybe we could have different icons to show a difference.

Pre-address verification:

Pre-launch:

Post-launch:

[danhauk]

Maybe we could have different icons to show a difference.

I agree. It would be great to have something more celebratory there. I'll work on something for that.

[scruffian]

Lets merge this and deal with the remaining issues in another PR. @niranjan-uma-shankar are you ok to create a new issue which compiles the remaining unaddressed feedback?

[niranjan-uma-shankar]

Lets merge this and deal with the remaining issues in another PR. @niranjan-uma-shankar are you ok to create a new issue which compiles the remaining unaddressed feedback?

Happy to do it @scruffian.

[scruffian]

Great 🚢