Site Settings: Remove Disabled Input for WordPress Version #32457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arunsathiya
added
[Status] Needs Review
ryelle
reviewed
May 28, 2019
| /> | ||
| <FormLabel | ||
| className="site-settings__wordpress-version" | ||
| htmlFor="wpversion" |
There was a problem hiding this comment.
Can this be changed to a different component? ie, not FormLabel – there is no input with ID wpversion for this to label anymore (and if somehow there is, in some other component on the page, it shouldn't attach to this label)
There was a problem hiding this comment.
👍
Updated the PR to just use a <strong> tag, would that be okay?
There was a problem hiding this comment.
Better now! :-) There's also FormFieldset component which isn't semantically correct now.
There was a problem hiding this comment.
I updated it to wrap with Fragment. :)
simison
reviewed
May 29, 2019
lancewillett
added
[Status] Needs Rebase
and removed
[Status] Needs Design Review
lancewillett
suggested changes
May 5, 2020
lancewillett
removed
the
[Status] Needs Review
|
Done, thank you! :) |
lancewillett
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
On a Jetpack connected site, visit
/settings/generaland check the WordPress version.Current:
Proposed:
cc @simison, @drw158
See #31207 and #26982 for some context on this