Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite afterLayoutFlush as a generic TS function. #32926

Merged
merged 6 commits into from May 29, 2019
Merged

Rewrite afterLayoutFlush as a generic TS function. #32926

merged 6 commits into from May 29, 2019

Commits on May 28, 2019

  1. Rewrite afterLayoutFlush as a generic TS function. 

    It now takes a function and returns a cancelable function of the same
type. This is a stricter contract that helps avoid typing errors in
consumers of this library.
    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    9e42df4 View commit details
    Browse the repository at this point in the history

  2. Remove redundant (and incorrect) JSDoc types

    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    fb5e6a0 View commit details
    Browse the repository at this point in the history

  3. Remove redundant return type from function.

    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    1ef3c38 View commit details
    Browse the repository at this point in the history

  4. Set timeout handle type more explicitly

    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    b660050 View commit details
    Browse the repository at this point in the history

  5. Use global type for timer handle.

    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    166a47d View commit details
    Browse the repository at this point in the history

  6. Remove ESLint disabling.

    @sgomes
    sgomes committed May 28, 2019
    Copy the full SHA
    884ae27 View commit details
    Browse the repository at this point in the history