Signup: reset signup state before navigation to destination outside Calypso #34078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Status] Needs Review
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~23 bytes removed 📉 [gzipped]) Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
…alypso The code path that handled navigation outside Calypso (typically site frontend by virtue of the `getSiteDestination` function) didn't call `signupFlowController.reset()`, leaving the signup state in Redux (and in IndexedDB) and causing weird behavior should we return to `/start` again shortly after. This patch also unifies the code paths that handle inside- and outside-Calypso destinations, as there is no longer any difference between them. The inside- one used to use `page( ... )` to navigate, but that's no longer true. Also removes the `defer` call that was needed for Flux, but is not needed in Redux-only code.
jsnajdr
force-pushed
the
fix/signup-reset-after-complete
branch
from
f0e0717
to
fb7526a
Compare
|
This PR has been marked as stale due to lack of activity within the last 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code path that handled navigation outside Calypso (typically site frontend by virtue of the
getSiteDestinationfunction) didn't callsignupFlowController.reset(), leaving the signup state in Redux (and in IndexedDB) and causing weird behavior should we return to/startagain shortly after.This patch also unifies the code paths that handle inside- and outside-Calypso destinations, as there is no longer any difference between them. The inside- one used to use
page( ... )to navigate, but that's no longer true.Also removes the
defercall that was needed for Flux, but is not needed in Redux-only code.How to test:
Go through a flow that has
getSiteDestinationas destination and doesn't add any cart items that would cause a "layover" at the Calypso checkout page, but goes there directly. One example is the/start/blogflow where you select a free domain and the free plan.After arriving at the destination site frontend, press the Back button. The flow should start again rather than freezing in a weird state (typically the "Awesome" page with big WP logo).