Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing: Differentiate between the Edit and More button clicks in Tracks #34285

Merged
merged 1 commit into from Jul 2, 2019

Conversation

sixhours
Copy link
Contributor

Changes proposed in this Pull Request

  • We currently log the "Edit sharing buttons" and "Add “More” button" as a single click event in Tracks, but it would be helpful to know if people are using one but not the other. This PR checks the visibility property of the button component to determine which button is being clicked.

Screen Shot 2019-06-25 at 5 10 19 PM

Testing instructions

  • Switch to this PR
  • Navigate to /marketing/sharing-buttons/
  • Open the browser inspector and copy and paste the following into your browser console so you can see Tracks events fire in real time: localStorage.setItem( 'debug', 'calypso:analytics*' );. Hit Enter, then refresh the page.
  • Click on the "Edit sharing buttons" button and check the console; you should see an event fire named calypso_sharing_buttons_edit_button_click
  • Close the panel and click on the "Add "More" button" button and check the console; you should see an event fire named calypso_sharing_buttons_more_button_click

Fixes #32226

@sixhours sixhours added the [Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons. label Jun 25, 2019
@sixhours sixhours requested a review from robertf4 June 25, 2019 21:11
@sixhours sixhours self-assigned this Jun 25, 2019
@sixhours sixhours added this to In Progress in Fixing the Flows via automation Jun 25, 2019
@matticbot
Copy link
Contributor

@sixhours sixhours moved this from In Progress to Needs Review in Fixing the Flows Jun 25, 2019
@sixhours sixhours added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 25, 2019
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~19 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
marketing       +164 B  (+0.0%)      +19 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@donpark donpark self-requested a review July 2, 2019 04:42
Fixing the Flows automation moved this from Needs Review to Reviewed Jul 2, 2019
Copy link
Contributor

@donpark donpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donpark donpark added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 2, 2019
@sixhours sixhours merged commit 5baa242 into master Jul 2, 2019
Fixing the Flows automation moved this from Reviewed to Done Jul 2, 2019
@sixhours sixhours deleted the update/tracks-events-sharing-buttons branch July 2, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Sharing Features and settings for sharing posts across different platforms, including sharing buttons.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Sharing Settings: Move "Add more" button into "Edit sharing buttons"
3 participants