Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Overflow Fade In Stats Page "Post Published" Overflow #36085

Merged
merged 3 commits into from Sep 14, 2019

Conversation

cbauerman
Copy link
Contributor

@cbauerman cbauerman commented Sep 13, 2019

Changes proposed in this Pull Request

  • Use color scheme in post title fade on stats page

Testing instructions

  1. Navigate to /stats/day on WordPress.com with a more unconventional color scheme set ( Nightfall, Sakura, etc. )
  2. Confirm the fade on the posts titles when mousing over a day in the bar chart with posts are a WordPress-y blue

Screen Shot 2019-09-13 at 11 48 13 AM

3. Repeat steps one and two on the branch 4. Confirm the title now blends into the background as it overflows

Screen Shot 2019-09-13 at 2 10 19 PM

Fixes #34365

@cbauerman cbauerman added Stats Everything related to our analytics product at /stats/ [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Color Schemes labels Sep 13, 2019
@cbauerman cbauerman self-assigned this Sep 13, 2019
@matticbot
Copy link
Contributor

@cbauerman cbauerman added this to In Progress in Grand Meetup - Fixing the Flows via automation Sep 13, 2019
@cbauerman cbauerman moved this from In Progress to Needs Review in Grand Meetup - Fixing the Flows Sep 13, 2019
@mmtr mmtr self-requested a review September 13, 2019 16:19
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@cbauerman cbauerman changed the title Use Color Scheme In Stats Page Posts Fade Fix Overflow Fade In Stats Page "Post Published" Overflow Sep 13, 2019
Grand Meetup - Fixing the Flows automation moved this from Needs Review to Reviewed Sep 14, 2019
Copy link
Member

@mmtr mmtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this works great. Thanks @cbauerman!

@cbauerman cbauerman added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Sep 14, 2019
@cbauerman cbauerman force-pushed the fix/user-color-scheme-in-stats-fade branch from 333b9e7 to e438e4d Compare September 14, 2019 14:24
@cbauerman cbauerman merged commit d2f52ea into master Sep 14, 2019
Grand Meetup - Fixing the Flows automation moved this from Reviewed to Done Sep 14, 2019
@cbauerman cbauerman deleted the fix/user-color-scheme-in-stats-fade branch September 14, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stats Everything related to our analytics product at /stats/
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Stats Chart Tabs: "Post Published" Gradient
4 participants