New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Overflow Fade In Stats Page "Post Published" Overflow #36085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbauerman
added
Stats
Everything related to our analytics product at /stats/
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Color Schemes
labels
Sep 13, 2019
cbauerman
moved this from In Progress
to Needs Review
in Grand Meetup - Fixing the Flows
Sep 13, 2019
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
mmtr
reviewed
Sep 13, 2019
cbauerman
changed the title
Use Color Scheme In Stats Page Posts Fade
Fix Overflow Fade In Stats Page "Post Published" Overflow
Sep 13, 2019
mmtr
reviewed
Sep 13, 2019
mmtr
approved these changes
Sep 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this works great. Thanks @cbauerman!
cbauerman
added
[Status] Ready to Merge
and removed
[Status] Needs Review
The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
labels
Sep 14, 2019
Co-Authored-By: Miguel Torres <miguel.torres@automattic.com>
cbauerman
force-pushed
the
fix/user-color-scheme-in-stats-fade
branch
from
September 14, 2019 14:24
333b9e7
to
e438e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
/stats/day
on WordPress.com with a more unconventional color scheme set ( Nightfall, Sakura, etc. )3. Repeat steps one and two on the branch 4. Confirm the title now blends into the background as it overflows
Fixes #34365