New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine WordAds Earnings + Settings into a single page #36970
base: trunk
Are you sure you want to change the base?
Conversation
…y content and NHT to the terms checkbox.
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~2492 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Still need to fix `className should follow CSS namespace guidelines` errors.
All in all, I think this is going to be a big improvement. It feels much cleaner/streamlined. Just a couple notes I made above, maybe we can wrangle a designer to help us make the cards a little more blended. |
Planning to circle back on this in the next few weeks. |
|
||
return ( | ||
<div> | ||
<SectionHeader label={ translate( 'Ad Placements' ) }> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 30 times:
translate( 'Additional ad placements' )
ES Score: 9
See 1 additional suggestions in the PR translation status page
This PR has been marked as stale due to lack of activity within the last 30 days. |
Changes proposed in this Pull Request
I left the scaffolding in place for tabs in case one of the other sections will use that in the future.
Testing instructions
Lets start with testing around the UI, make sure everything makes sense and we're happy with the overall direction. Then we can dive into the technicals and likely add some more cleanup.
Here's what you should see while testing:
Application view
WordPress.com Site view
Jetpack site view