Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show backup screenshot in activity log #38620

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

pidgeonman
Copy link
Contributor

@pidgeonman pidgeonman commented Dec 31, 2019

Changes proposed in this Pull Request

  • Render an image component to display a screenshot of a backup in the Activity Log entry.
  • The image generation was a meetup project.

Testing instructions

  1. Apply D36774 and related diffs. Make sure you sandbox both wpcom and vaultpress.
  2. Trigger a backup. Take note of the period number.
  3. Run the job async_store_backup_screenshot() by hand.
  4. You should see the generated screenshot in the AL. It can take some time for it to be generated and saved, so keep refreshing.

OPTIONAL:

Use the API console.

@pidgeonman pidgeonman requested a review from a team December 31, 2019 04:56
@pidgeonman pidgeonman self-assigned this Dec 31, 2019
@matticbot
Copy link
Contributor

@pidgeonman
Copy link
Contributor Author

This is a WIP. I need to determine how to get the period parameter. Currently using the rewindId, but it doesn't seem to be the same as the period. However, the basic image retrieval from the backend and rendering is working.

@matticbot
Copy link
Contributor

matticbot commented Dec 31, 2019

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~669 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
stats             +660 B  (+0.1%)     +277 B  (+0.1%)
activity          +660 B  (+0.2%)     +277 B  (+0.3%)
woocommerce        +72 B  (+0.0%)      +25 B  (+0.0%)
settings           +72 B  (+0.0%)      +23 B  (+0.0%)
people             +72 B  (+0.0%)      +23 B  (+0.0%)
hosting            +72 B  (+0.1%)      +23 B  (+0.1%)
account            +72 B  (+0.0%)      +21 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~349 bytes added 📈 [gzipped])

name                                 parsed_size           gzip_size
async-load-signup-steps-clone-point       +660 B  (+0.4%)     +273 B  (+0.8%)
async-load-design-playground               +72 B  (+0.0%)      +25 B  (+0.0%)
async-load-design-blocks                   +72 B  (+0.0%)      +26 B  (+0.0%)
async-load-design                          +72 B  (+0.0%)      +25 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

{ 'rewind__backup_complete_full' === activityName && (
<Image
src="data:image/gif;base64,R0lGODlhAQABAAD/ACwAAAAAAQABAAACADs="
alt="Backup screenshot"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this phrase be translatable?

@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been marked as stale and will be closed in seven days. This happened because:

  • It has been inactive in the past 9 months.
  • It isn't a project or a milestone, and hasn’t been labeled `[Pri] Blocker`, `[Pri] High`, `[Status] Keep Open`, or `OSS Citizen`.

You can keep the issue open by adding a comment. If you do, please provide additional context and explain why you’d like it to remain open. You can also close the issue yourself — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Oct 12, 2020
@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:14
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 20, 2020
@stale stale bot removed the [Status] Stale label Nov 20, 2020
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Activity Log [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants