Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Apps: Crop Google Play badge image #38940

Merged
merged 2 commits into from Jan 20, 2020

Conversation

mmtr
Copy link
Member

@mmtr mmtr commented Jan 20, 2020

Part of #38907
Follows up #38905

Changes proposed in this Pull Request

The Google Play badge image has some transparent space around it which causes some alignment issues when using it along with the App Store bade image (since this one doesn't have any transparent space).

Google Play App Store
Screenshot 2020-01-20 at 13 18 58 Screenshot 2020-01-20 at 13 19 06
Link to image Link to image

This PR includes a CSS hack that crops the Google Play image in order to have a size-equivalent image to the App Store one in order to prevent those alignment issues.

That allowed to align the banner to the right when we display one single store button in the Customer Home's Go Mobile card suggested by @sixhours in #38905 (comment).

Screenshots

/home/:site

Device Before After
Desktop Screenshot 2020-01-20 at 13 08 59 Screenshot 2020-01-20 at 13 10 07
iPhone Screenshot 2020-01-20 at 13 11 44 Screenshot 2020-01-20 at 13 13 03
Android Screenshot 2020-01-20 at 13 13 20 Screenshot 2020-01-20 at 13 13 40
Other mobile device Screenshot 2020-01-20 at 13 11 10 Screenshot 2020-01-20 at 13 11 28

/me/get-apps and /checklist/:site

Device Before After
Desktop Screenshot 2020-01-20 at 13 07 42 Screenshot 2020-01-20 at 13 07 54
Mobile Screenshot 2020-01-20 at 13 08 05 Screenshot 2020-01-20 at 13 08 13

Testing instructions

Access the path listed above and verify the mobile stores badges are displayed correctly according to the screenshots.

@mmtr mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2020
@mmtr mmtr requested a review from a team January 20, 2020 12:32
@mmtr mmtr self-assigned this Jan 20, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~26 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
home       +121 B  (+0.0%)      +26 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@sixhours
Copy link
Contributor

This works a charm! 👍

@mmtr mmtr merged commit a518048 into master Jan 20, 2020
@mmtr mmtr deleted the update/mobile-apps-android-badge-alignment branch January 20, 2020 15:14
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants