Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Fix some usability issues with the custom nameservers controls #39539

Merged

Conversation

hambai
Copy link
Contributor

@hambai hambai commented Feb 19, 2020

Changes proposed in this Pull Request

  • Move the notice above and outside the card.
  • Change the input placeholders to "eg: ns1.example.com" and "eg: ns2.example.com".
  • Make the field label bold

Use custom nameservers (before):

Screenshot 2020-02-19 at 14 18 10

Use custom nameservers (after):

Screenshot 2020-02-19 at 14 18 15

Testing instructions

  • Open "Name Servers and DNS" and disable the "Use WordPress.com Name Servers" toggle
  • verify that the notice is outside the card, the placeholders are updated and the label is bold

@hambai hambai added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Feb 19, 2020
@hambai hambai requested review from fditrapani and a team February 19, 2020 12:33
@hambai hambai self-assigned this Feb 19, 2020
@matticbot
Copy link
Contributor

<span>{ translate( 'Use Custom Name Servers:' ) }</span>

{ this.warning() }
<strong>{ translate( 'Use custom name servers:' ) }</strong>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~63 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +179 B  (+0.0%)      +63 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@klimeryk klimeryk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@klimeryk klimeryk added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 19, 2020
Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Thanks for the updates!

@hambai hambai merged commit 961bf73 into master Feb 20, 2020
@hambai hambai deleted the update/domain-management-name-servers-usability-fixes branch February 20, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants