-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: Add plan upsell when non primary domain is purchased #39682
Conversation
Functionally, this works as documented. The one thing I found was that the text wasn't that easy to read, and I found it hard to pick out the domains that were involved. For me, the text was really dense and low-contrast, so I didn't pick up on the underlying CTA on my first pass. Maybe splitting the text up into three clear paragraphs would help with making it easier to read? Giving the domains some emphasis, like making them bold, could also help on that front. @fditrapani, please feel free to weigh in on the design side of things. We can easily iterate on this if you'd prefer. |
Good points @daledupreez. Splitting it up into paragraphs can definitely help with the radibility. The bolding might be much with three domain names listed there. I would split it up like this:
|
I got my sandbox updated and was able to test this. This works as described! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks much better. Thanks for the updates @eltongo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me too with one possible copy tweak that is not blocking!
<div> | ||
<p> | ||
{ i18n.translate( | ||
'Your existing domain, %(primaryDomain)s, is the primary domain visitors ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor thought on copy: maybe this would be clearer if we wrote:
Your existing domain, %(primaryDomain)s, will still be the primary domain visitors see when they visit your site.
(The change is from "is the primary domain" to "will still be".)
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~257 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/2830213 Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This PR adds a plan upsell card after the purchase of a domain by free users as part of this test: p99Zz8-10j-p2
Testing instructions
Recommended to use Store Sandbox:
Also verify that the functionality works, and that clicking the button takes you to the right page.