Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout: Add plan upsell when non primary domain is purchased #39682

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

eltongo
Copy link
Contributor

@eltongo eltongo commented Feb 25, 2020

Changes proposed in this Pull Request

This PR adds a plan upsell card after the purchase of a domain by free users as part of this test: p99Zz8-10j-p2

Testing instructions

Recommended to use Store Sandbox:

  • Select a site that is on a free plan
  • Purchase a domain
  • Right after the purchase, in the Thank You page, you should see this card among others:

Screenshot 2020-02-26 at 3 08 54 PM

Also verify that the functionality works, and that clicking the button takes you to the right page.

@eltongo eltongo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. Post Checkout labels Feb 25, 2020
@eltongo eltongo requested review from fditrapani and a team February 25, 2020 18:20
@eltongo eltongo self-assigned this Feb 25, 2020
@matticbot
Copy link
Contributor

@fditrapani
Copy link
Contributor

I just made a purchase, while sandboxed, and didn't see the card. This is what I got:

image

Do I need to apply any patches or anything? and should I have seen the upgrade nudge in a cart (or has that not merged yet?)? I didn't see it.

@eltongo
Copy link
Contributor Author

eltongo commented Feb 26, 2020

I just made a purchase, while sandboxed, and didn't see the card. This is what I got:

image

Do I need to apply any patches or anything? and should I have seen the upgrade nudge in a cart (or has that not merged yet?)? I didn't see it.

Probably you need to update your sandbox.

@daledupreez
Copy link
Contributor

Functionally, this works as documented.

The one thing I found was that the text wasn't that easy to read, and I found it hard to pick out the domains that were involved. For me, the text was really dense and low-contrast, so I didn't pick up on the underlying CTA on my first pass. Maybe splitting the text up into three clear paragraphs would help with making it easier to read? Giving the domains some emphasis, like making them bold, could also help on that front.

@fditrapani, please feel free to weigh in on the design side of things. We can easily iterate on this if you'd prefer.

@fditrapani
Copy link
Contributor

fditrapani commented Feb 26, 2020

Maybe splitting the text up into three clear paragraphs would help with making it easier to read? Giving the domains some emphasis, like making them bold, could also help on that front.

Good points @daledupreez. Splitting it up into paragraphs can definitely help with the radibility. The bolding might be much with three domain names listed there. I would split it up like this:

Your existing domain, example.wordpress.com, is the primary domain people see when they visit your site. domain.tld will redirect to example.wordpress.com.

Upgrade to a paid plan to make domain.tld the domain people see when they visit your site.

@fditrapani
Copy link
Contributor

I got my sandbox updated and was able to test this. This works as described!

@fditrapani
Copy link
Contributor

Here's a quick mockup to help with breaking up the copy:

image

Copy link
Contributor

@fditrapani fditrapani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks much better. Thanks for the updates @eltongo!

Copy link
Contributor

@daledupreez daledupreez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me too with one possible copy tweak that is not blocking!

<div>
<p>
{ i18n.translate(
'Your existing domain, %(primaryDomain)s, is the primary domain visitors ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor thought on copy: maybe this would be clearer if we wrote:
Your existing domain, %(primaryDomain)s, will still be the primary domain visitors see when they visit your site.
(The change is from "is the primary domain" to "will still be".)

@eltongo eltongo merged commit 0cf33bc into master Feb 26, 2020
@eltongo eltongo deleted the update/thank-you-plan-upsell branch February 26, 2020 15:33
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 26, 2020
@matticbot
Copy link
Contributor

matticbot commented Feb 28, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~257 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout      +1116 B  (+0.1%)     +257 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/2830213

Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented May 26, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management. Post Checkout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants