Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration: add header to confirmation dialog #39745

Merged

Conversation

jonathansadowski
Copy link
Member

Changes proposed in this Pull Request

  • Update the confirmation modal to include a header

Before:
image

After:
image

Testing instructions

  • Click on "Import" in the sidebar while a Simple (or Atomic) site is selected.
  • Select "WordPress".
  • Enter the URL to a Jetpack-connected WordPress site.
  • Select "Import Everything".
  • Continue through the flow until you see the confirmation dialog.

Fixes #39580

@jonathansadowski jonathansadowski added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. WP Migration Issues and PRs specific to the WP Migration Project (pbkcP4-8-p2) labels Feb 27, 2020
@jonathansadowski jonathansadowski requested a review from a team February 27, 2020 17:35
@matticbot
Copy link
Contributor

@jonathansadowski
Copy link
Member Author

@danhauk #39580 has a different design for the header within the confirmation dialog, but there were already explicit styles in place, so I didn't overwrite them. Let me know if you'd like me to do so.

I also removed the suggested sentence about returning the site to the current state, as that won't always be true if a backup of the target site isn't completed ahead of the restore.

Copy link
Member

@mattsherman mattsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. An improvement over current UX.

The line height for the Dialog is too large, but that is a general issue, so I've created a separate issue to address that...

#39748

@jonathansadowski
Copy link
Member Author

Thanks for the review

@jonathansadowski jonathansadowski merged commit 1a605b6 into master Feb 27, 2020
@jonathansadowski jonathansadowski deleted the update/migration--confirmation-modal-header branch February 27, 2020 20:51
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 27, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~16 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
migrate       +127 B  (+0.1%)      +16 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WP Migration Issues and PRs specific to the WP Migration Project (pbkcP4-8-p2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration: Confirmation modal needs a heading
3 participants