Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite-checkout: add missing cart events #39774

Draft
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

nbloomf
Copy link
Contributor

@nbloomf nbloomf commented Feb 28, 2020

Changes proposed in this Pull Request

  • Adds calypso_cart_product_add and calypso_cart_product_remove events to composite checkout.

Testing instructions

Enter checkout, proceed to the review order step, and remove an item from your cart. Verify that the tracks events fire.

image

image

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~136 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout       +660 B  (+0.0%)     +136 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@lancewillett
Copy link
Contributor

GitHub workflow note — please use status labels as much as you can. There is automation available with GitHub project boards. Moving it between columns changes the status for you, etc.

What's the status of this one — Needs Review maybe?

@lancewillett lancewillett added [Status] In Progress [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. labels Mar 12, 2020
@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:13
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Status] In Progress [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants