Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct spelling and capitalization of Media Library #39984

Merged
merged 1 commit into from Mar 9, 2020

Conversation

kriskarkoski
Copy link
Contributor

Library was originally misspelled as libary and media library was not capitalized

I do not have local Calypso development environment so was not able to follow https://github.com/Automattic/wp-calypso/blob/master/docs/merge-checklist.md but I do not believe it should be necessary for this small of a change.

Changes proposed in this Pull Request

  • Fixed spelling and capitalization of Media Library in Guided Tours

Testing instructions

Fixes #39981

Library was originally misspelled as libary and media library was not capitalized
@kriskarkoski kriskarkoski requested a review from a team as a code owner March 9, 2020 18:09
@matticbot
Copy link
Contributor

@blowery blowery added the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 9, 2020
@blowery
Copy link
Contributor

blowery commented Mar 9, 2020

@kriskarkoski nice work, thanks! I added the string freeze label to try and get translations for this as quickly as possible.

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -61,7 +61,7 @@ export const MediaBasicsTour = makeTour(
<Fragment>
<p>
{ translate(
'You can also drag-and-drop image and video files from your computer into your media library.'
'You can also drag-and-drop image and video files from your computer into your Media Library.'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.

@lancewillett
Copy link
Contributor

lancewillett commented Mar 9, 2020

Nice pull request, @kriskarkoski 👍

Welcome back to WordPress.com development!

@lancewillett lancewillett added [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Status] Ready to Merge labels Mar 9, 2020
@blowery
Copy link
Contributor

blowery commented Mar 9, 2020

@kriskarkoski to be clear too, you don't have to wait on translations here, I was only adding the label to get them queued up before landing on master. We fall back to the old translations while we're waiting on the new ones, and that's perfect for this case.

@lancewillett lancewillett merged commit a14a2c8 into master Mar 9, 2020
@lancewillett lancewillett deleted the fix/guided-tour-media-spelling branch March 9, 2020 20:05
@matticbot matticbot removed the [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging label Mar 9, 2020
@tyxla
Copy link
Member

tyxla commented Mar 9, 2020

Thank you for the fix @kriskarkoski 🙌

@kriskarkoski
Copy link
Contributor Author

Thanks for merging @lancewillett and for the clarification @blowery. I was being extra cautious since I haven't been in here much to date :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Library: Welcome Message Typo
6 participants