New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct spelling and capitalization of Media Library #39984
Conversation
Library was originally misspelled as libary and media library was not capitalized
@kriskarkoski nice work, thanks! I added the |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -61,7 +61,7 @@ export const MediaBasicsTour = makeTour( | |||
<Fragment> | |||
<p> | |||
{ translate( | |||
'You can also drag-and-drop image and video files from your computer into your media library.' | |||
'You can also drag-and-drop image and video files from your computer into your Media Library.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆗 This change will be queued for retranslation. We'll use the existing translations in the meantime.
Nice pull request, @kriskarkoski 👍 Welcome back to WordPress.com development! |
@kriskarkoski to be clear too, you don't have to wait on translations here, I was only adding the label to get them queued up before landing on master. We fall back to the old translations while we're waiting on the new ones, and that's perfect for this case. |
Thank you for the fix @kriskarkoski 🙌 |
Thanks for merging @lancewillett and for the clarification @blowery. I was being extra cautious since I haven't been in here much to date :) |
Library was originally misspelled as libary and media library was not capitalized
I do not have local Calypso development environment so was not able to follow https://github.com/Automattic/wp-calypso/blob/master/docs/merge-checklist.md but I do not believe it should be necessary for this small of a change.
Changes proposed in this Pull Request
Testing instructions
Fixes #39981