Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create the ThreatItem component #40003

Merged
merged 8 commits into from
Mar 17, 2020
Merged

Create the ThreatItem component #40003

merged 8 commits into from
Mar 17, 2020

Conversation

rcanepa
Copy link
Contributor

@rcanepa rcanepa commented Mar 10, 2020

Changes proposed in this Pull Request

  • The goal of this is to create the Threat Card used on the main screen when threats are found.

Testing instructions

See 1151678672052943-as-1165217655856094.

Screenshots

Mobile

image

image

Desktop

image

image

@rcanepa rcanepa added the Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) label Mar 10, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=add/threat-summary-threat-card

@matticbot
Copy link
Contributor

matticbot commented Mar 10, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~318 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-jetpack-cloud      +2089 B  (+0.1%)     +318 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@rcanepa rcanepa force-pushed the add/threat-summary-threat-card branch from 296bac6 to e7c0c08 Compare March 10, 2020 16:18
@rcanepa rcanepa added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 10, 2020
@rcanepa
Copy link
Contributor Author

rcanepa commented Mar 11, 2020

Thank you @enejb for your comments! I have already pushed a new version that addresses all feedback.

@rcanepa rcanepa requested a review from enejb March 12, 2020 21:49
enejb
enejb approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@enejb enejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me. Thanks for all the fixes!

@enejb enejb added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 16, 2020
@rcanepa rcanepa merged commit fe89c7c into master Mar 17, 2020
@rcanepa rcanepa deleted the add/threat-summary-threat-card branch March 17, 2020 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enejb enejb enejb approved these changes

@robertf4 robertf4 Awaiting requested review from robertf4

@rcoll rcoll Awaiting requested review from rcoll

Assignees
No one assigned
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rcanepa @matticbot @enejb