New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Cloud: Add Scan Error Page #40219
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~128 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the translation/localization issue, everything looks fine.
<SecurityIcon className="scan__icon" icon="scan-error" /> | ||
<h1 className="scan__header">{ translate( 'Something went wrong' ) }</h1> | ||
<p> | ||
The scan did not complete successfully. In order to complete the scan you need to contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should translate
this text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left the translation issue as it is since mostly likely it will change in the future. :S
So I didn't want to translators working on translating something that would most likely change.
Changes proposed in this Pull Request
See:
Testing instructions
npm run start-jetpack-cloud
This page doesn't take into account the if threats are already found.