Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Cloud: Add Scan Error Page #40219

Merged
merged 1 commit into from Mar 18, 2020
Merged

Jetpack Cloud: Add Scan Error Page #40219

merged 1 commit into from Mar 18, 2020

Conversation

enejb
Copy link
Member

@enejb enejb commented Mar 17, 2020

Changes proposed in this Pull Request

  • This PR adds a basic Scan error page.
    See:

Screen Shot 2020-03-17 at 4 12 35 PM

Testing instructions

This page doesn't take into account the if threats are already found.

@enejb enejb added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Mar 17, 2020
@enejb enejb requested a review from a team March 17, 2020 15:16
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~128 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
jetpack-cloud       +527 B  (+0.2%)     +128 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the translation/localization issue, everything looks fine.

<SecurityIcon className="scan__icon" icon="scan-error" />
<h1 className="scan__header">{ translate( 'Something went wrong' ) }</h1>
<p>
The scan did not complete successfully. In order to complete the scan you need to contact
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should translate this text.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the translation issue as it is since mostly likely it will change in the future. :S
So I didn't want to translators working on translating something that would most likely change.

@rcanepa rcanepa added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 18, 2020
@enejb enejb merged commit 7e1c5be into master Mar 18, 2020
@enejb enejb deleted the add/scan-error-page branch March 18, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants