Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Cloud: Update support links #40281

Merged
merged 2 commits into from
Mar 20, 2020
Merged

Jetpack Cloud: Update support links #40281

merged 2 commits into from
Mar 20, 2020

Conversation

enejb
Copy link
Member

@enejb enejb commented Mar 19, 2020

Changes proposed in this Pull Request

This PR adds links to the jepack.com/support to the jetpack cloud.

After:
Screen Shot 2020-03-19 at 9 54 35 AM

Testing instructions

@matticbot
Copy link
Contributor

@enejb enejb self-assigned this Mar 19, 2020
@enejb enejb added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Mar 19, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~259 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
jetpack-cloud       +793 B  (+0.3%)     +259 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~6 bytes added 📈 [gzipped])

name                                                 parsed_size           gzip_size
async-load-landing-jetpack-cloud-components-sidebar        +26 B  (+0.2%)       +6 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

- updates the sidebar link to take users to jetpack.com/support
- update the link on the error page to take users to contact support page
Copy link
Contributor

@rcanepa rcanepa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @enejb !

@enejb enejb merged commit 3a6b12b into master Mar 20, 2020
@enejb enejb deleted the update/support-link-jpc branch March 20, 2020 07:46
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) Jetpack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants