Update DailyBackupStatus to use the backup from date selected + timezone #40496

cleacos · 2020-03-26T20:53:44Z

Changes proposed in this Pull Request

Adapt the DailyBackupStatus to use the backup for the selected date passed from BackupsPage. We apply the time zone of the site to the backup date and also the right format according to design.

Note: No styles applied.

Testing instructions

(see the animation attached)

Check if the display backup date-time is the expected on the site time zone
Set another time zone for your site and check again (1) if the backup date-time matches with the selected time zone.

Bonus:

If you don't have backup performed from today, check the expected copy
If you have a day with a failed backup, check the expected copy

matticbot · 2020-03-26T20:53:45Z

Test live: https://calypso.live/?branch=update/jetpack-cloud-backup-status-with-selected-backup-plus-timezone

matticbot · 2020-03-26T20:54:06Z

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~5 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +117 B  (+0.0%)       +5 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~13461 bytes added 📈 [gzipped])

name     parsed_size            gzip_size
backups     +70540 B  (+27.1%)   +13461 B  (+20.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

a8ci18n · 2020-03-26T21:01:28Z

client/landing/jetpack-cloud/components/daily-backup-status/index.jsx

+				</Button>
+
+				<div>
+					<strong>{ translate( 'Get Real-Time Backups' ) }</strong>


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 17 times:
translate( 'Get real-time backups' ) ES Score: 11
See 2 additional suggestions in the PR translation status page

rcoll

This looks great. Make sure canaries pass and then feel free to 🚢 .

- It should be implemented on DatePicker

- Include the rest of the activity from the selected date, including other backups from the date.

{ timezone, gmtOffset }

- Added functions to utils - Added displayable date as the design has - Render no backups from the date selected - Add some copies from the design

cleacos added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Mar 26, 2020

cleacos requested review from cbauerman and rcoll March 26, 2020 20:53

cleacos self-assigned this Mar 26, 2020

a8ci18n reviewed Mar 26, 2020

View reviewed changes

cleacos force-pushed the update/jetpack-backup-backuppage-create-backup-state-for-selected-date branch from e8bf6ac to 26fde4b Compare March 26, 2020 23:26

cleacos force-pushed the update/jetpack-cloud-backup-status-with-selected-backup-plus-timezone branch from 26376cf to a99497a Compare March 26, 2020 23:27

This was referenced Mar 27, 2020

Add/jetpack cloud backuppage indexed backup logs with timezone #40403

Closed

Create the backup state (last backup and activities) for the selected date #40469

Closed

cleacos requested a review from enejb March 27, 2020 12:28

cleacos changed the base branch from update/jetpack-backup-backuppage-create-backup-state-for-selected-date to master March 27, 2020 16:50

rcoll approved these changes Mar 27, 2020

View reviewed changes

cleacos force-pushed the update/jetpack-cloud-backup-status-with-selected-backup-plus-timezone branch from 8f93b98 to 3738dee Compare March 28, 2020 11:00

cleacos added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 28, 2020

cleacos added 12 commits March 30, 2020 08:02

Add function to create the indexed logs by date on site timezone

c439a54

Add isLoadingBackups to know when we are requesting the backup logs

5217e6a

Pass the oldest backup date available to the DatePicker

14b92b0

- It should be implemented on DatePicker

Create the backup state for the selected date with the last backup

6f4fcd3

- Include the rest of the activity from the selected date, including other backups from the date.

Fix: If we don't have backups on selected date, reset the state

3ec555b

Fix: on applySiteOffset the object fields should be timezone, gmtOffset

815c968

{ timezone, gmtOffset }

Set the initial state with a getDefaultState method

ecc4dd0

Update DailyBackupStatus to use the backup from date selected + timezone

7bc7728

- Added functions to utils - Added displayable date as the design has - Render no backups from the date selected - Add some copies from the design

Remove the "Date selected" from DatePicker (was for testing purpose)

8cd8f9e

Fix displayDate and displayTime args in the translation copy

78d5939

Fix: BackupsPage should initialize with the today as selected date

c3deb92

Minor code style improvement

1695ab9

cleacos force-pushed the update/jetpack-cloud-backup-status-with-selected-backup-plus-timezone branch from 3738dee to 1695ab9 Compare March 30, 2020 07:10

cleacos merged commit 3701a87 into master Mar 30, 2020

cleacos deleted the update/jetpack-cloud-backup-status-with-selected-backup-plus-timezone branch March 30, 2020 07:45

matticbot removed the [Status] Ready to Merge label Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update DailyBackupStatus to use the backup from date selected + timezone #40496

Update DailyBackupStatus to use the backup from date selected + timezone #40496

cleacos commented Mar 26, 2020

matticbot commented Mar 26, 2020

matticbot commented Mar 26, 2020 •

edited

a8ci18n Mar 26, 2020

rcoll left a comment

Update DailyBackupStatus to use the backup from date selected + timezone #40496

Update DailyBackupStatus to use the backup from date selected + timezone #40496

Conversation

cleacos commented Mar 26, 2020

Changes proposed in this Pull Request

Testing instructions

matticbot commented Mar 26, 2020

matticbot commented Mar 26, 2020 • edited

a8ci18n Mar 26, 2020

Choose a reason for hiding this comment

rcoll left a comment

Choose a reason for hiding this comment

matticbot commented Mar 26, 2020 •

edited