Posts: Improve Clarity of Scheduled Time #40843

Aurorum · 2020-04-07T10:58:56Z

Changes proposed in this Pull Request

This ensures that the scheduled time clearly states when the post is due to be released.

Testing instructions

A few things to check:

when the post is due to be released within a week, it shouldn't give the full date, but it should give the time (I would find this very helpful as someone who tries to schedule posts weekly at the same time, so I'm sure many others would too)
when the post is due to be released after a week, it should give the full date
"scheduled in" should be replaced with "scheduled for" (the latter gave the impression that was when the "Schedule" button was actually clicked, when that isn't what it conveys)

Before:

After:

Note: I made a few changes so that it displays the date and then "at" (eg. 27 April 2020 at 02:00) so that it's consistent with the wording for a post due to be published in under 7 days.

Follows up to #40779 and #40584
Fixes #12052

a8ci18n · 2020-04-07T11:16:27Z

client/my-sites/post-relative-time-status/index.jsx

+					? scheduledDate.calendar()
+					: scheduledDate.format( 'LL' ) +
+					  ' ' +
+					  this.props.translate( 'at', {


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 3 times:
translate( 'at', { context: 'time comment was posted'} ) ES Score: 7
See 1 additional suggestions in the PR translation status page

ℹ️ This context is really long. Are you sure you don't want to use a translator comment instead?

sixhours · 2020-04-07T12:42:20Z

This is so much clearer. 👍 /cc @Automattic/dotcom-manage-design because I worry the strings are too long for a relatively small space.

I wonder if we shortened it to something like "Scheduled for Feb 5" with a tooltip that specified the exact time? That's not particularly elegant, though...

Aurorum · 2020-04-07T12:57:03Z

The months could be shortened (eg. April -> Apr) like the text before it. But, to be honest, I'm not sure that'll make a great difference. :)

client/my-sites/post-relative-time-status/index.jsx

a8ci18n · 2020-04-07T14:01:18Z

client/my-sites/post-relative-time-status/index.jsx

+					  ' ' +
+					  scheduledDate.format( 'LT' );
+
+			statusText = this.props.translate( 'scheduled for %(scheduledTime)s', {


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 1 times:
translate( 'scheduled %(scheduledTime)s' ) ES Score: 7

client/my-sites/post-relative-time-status/index.jsx

Co-Authored-By: Alex Kirk <akirk@users.noreply.github.com>

client/my-sites/post-relative-time-status/index.jsx

millerf · 2020-04-07T19:40:16Z

I worry the strings are too long for a relatively small space

It definitely seems a bit crowded on small screens.

I think the year is a useless piece information, unless it is more than one year in the future. If you are in December 2020, and it says "scheduled for Jan, 5th". It is straightforward that means January 2021...

Aurorum · 2020-04-07T20:38:08Z

Thanks for looking at this! I agree that hiding the year if the post is due to be released within 365 days is an easy way to cut some space! I've made that change now. :)

With a post due to be released within a year:

With a post due to be released after a year:

gwwar · 2020-04-07T21:33:28Z

@sixhours and @Automattic/dotcom-manage-design I'm not sure we need to display multiple dates in this case.

Looking back at wp-admin the date shown is contextual to the post status. For published, we show last publish date, for drafts last modified, and for scheduled the most important piece of information is when it will be published in the future vs the last edit. There's a bit of ambiguity in Calypso, with the icon over a text label, which is maybe why we tried showing both?

akirk · 2020-04-07T21:39:45Z

client/my-sites/post-relative-time-status/index.jsx

+			const now = moment();
+			const scheduledDate = moment( this.props.post.date );
+			// If the content is scheduled to be release within a year, do not display the year at the end
+			const displayDate = scheduledDate.diff( now, 'years' ) > 0 ? 'll' : 'D MMM';


D MMM assumes that languages use a day-month format but some use month-day. Couldn't we rather replace the Y from the generated ll? Something like this:

if ( scheduledDate.diff( now, 'years' ) < 1 ) scheduledTime.replace( scheduledDate.format( 'Y' ), '' );

@mmtr could we please get this addressed also? Thanks!

Thanks, fixed! :)

millerf · 2020-04-08T06:18:15Z

There's a bit of ambiguity in Calypso, with the icon over a text label,

@gwwar It has always been misleading on calypso. Mainly because the icon is always the same, so there is no way to distinguish which date is being displayed.
That was my aim on this issue: if I remember well, the "modified", "published" and "future" dates were used (but only on "pages"), "post" weren't using the "published" dates.

Now that "posts" and "pages" are using the same component to display this information, it will be way easier to fix it, although it goes out of the scope of this very issue, and we definitely need some guideline from @sixhours to know where we are headed. Maybe getting slightly different icons to carry the ideas of "last modified", "published on" and "scheduled for" would be enough?

Idea	Icon
Last modified
Published
Scheduled for

sixhours · 2020-04-08T14:33:30Z

For this PR, I like that the post date is clear about what time it is scheduled for.

I agree with @gwwar that an easy fix to reduce the amount of copy is to remove the "last modified" date entirely and only display the date it's published, or the date it's scheduled.

But I don't know how that stacks up against past changes, I'm coming into this in the middle. Apologies if I'm confusing things even more. :)

gwwar · 2020-04-08T16:29:33Z

I agree with @gwwar that an easy fix to reduce the amount of copy is to remove the "last modified" date entirely and only display the date it's published, or the date it's scheduled.
But I don't know how that stacks up against past changes, I'm coming into this in the middle. Apologies if I'm confusing things even more. :)

Would you like to pick @lcollette? I'm in favor of dropping the less important date, so we can have a proper text label. (I always find mystery icons without a text label to be super confusing). Happy to defer here though if y'all had other thoughts.

lcollette · 2020-04-09T18:38:39Z

I agree with @gwwar that an easy fix to reduce the amount of copy is to remove the "last modified" date entirely and only display the date it's published, or the date it's scheduled.

I also agree with removing the last modified date entirely. The date it's published, or scheduled to publish, seems more useful.

mmtr · 2020-04-10T13:54:41Z

I also agree with removing the last modified date entirely. The date it's published, or scheduled to publish, seems more useful.

@lcollette should we remove the last modified date then on this PR? Or are you suggesting to do it as a follow-up?

gwwar · 2020-04-10T16:53:41Z

@lcollette should we remove the last modified date then on this PR? Or are you suggesting to do it as a follow-up?

I think either would be fine provided the follow up PR is relatively quick to land after.

mmtr · 2020-04-13T09:41:24Z

@Aurorum This should be ready to go after addressing the linting issues and taking into consideration the current locale date format when removing the year from the datetime.

Just making sure we don't merge this before addressing the pending issues

a8ci18n · 2020-04-13T11:04:31Z

client/my-sites/post-relative-time-status/index.jsx

+			const scheduledDate = moment( this.props.post.date );
+			// If the content is scheduled to be release within a year, do not display the year at the end
+			const scheduledTime = scheduledDate.calendar( null, {
+				sameElse: this.props.translate( 'll [at] LT', {


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 20 times:
translate( 'LL [at] LT' ) ES Score: 12

Aurorum · 2020-04-13T11:07:36Z

I think both should now be fixed, thanks @mmtr! :)

mmtr

Thanks @Aurorum! This tests well for me.

Before	After

We can possibly use a sentence case notation when the scheduled date is today/tomorrow in order to avoid a capitalized Today/Tomorrow, but not a blocker here.

mmtr · 2020-04-14T09:29:23Z

Filed #41075 to follow up on removing the last modified date on scheduled posts.

Posts: Improve Clarity of Scheduled Time

39a7961

matticbot added the OSS Citizen label Apr 7, 2020

Aurorum mentioned this pull request Apr 7, 2020

Harmonize post and pages views #40584

Merged

Ensure phrasing is consistent

6c7b318

a8ci18n reviewed Apr 7, 2020

View reviewed changes

mmtr requested a review from a team April 7, 2020 11:52

mmtr assigned Aurorum Apr 7, 2020

mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 7, 2020

akirk reviewed Apr 7, 2020

View reviewed changes

client/my-sites/post-relative-time-status/index.jsx Outdated Show resolved Hide resolved

client/my-sites/post-relative-time-status/index.jsx Outdated Show resolved Hide resolved

Fix translate string comment

65595fd

a8ci18n reviewed Apr 7, 2020

View reviewed changes

akirk reviewed Apr 7, 2020

View reviewed changes

client/my-sites/post-relative-time-status/index.jsx Outdated Show resolved Hide resolved

Aurorum and others added 2 commits April 7, 2020 16:50

Use sameElse

9d0565c

Co-Authored-By: Alex Kirk <akirk@users.noreply.github.com>

Fix brackets of suggestion

3ffdca6

millerf reviewed Apr 7, 2020

View reviewed changes

client/my-sites/post-relative-time-status/index.jsx Show resolved Hide resolved

client/my-sites/post-relative-time-status/index.jsx Outdated Show resolved Hide resolved

Hide year if the post is to be released within 365 days

9b9c1b8

Fix linter

d7bcbc4

akirk reviewed Apr 7, 2020

View reviewed changes

lcollette previously approved these changes Apr 9, 2020

View reviewed changes

Replace the year instead

875122d

a8ci18n reviewed Apr 13, 2020

View reviewed changes

mmtr approved these changes Apr 13, 2020

View reviewed changes

mmtr merged commit d5304d7 into Automattic:master Apr 13, 2020

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 13, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Posts: Improve Clarity of Scheduled Time #40843

Posts: Improve Clarity of Scheduled Time #40843

Aurorum commented Apr 7, 2020 •

edited

Loading

a8ci18n Apr 7, 2020

sixhours commented Apr 7, 2020 •

edited

Loading

Aurorum commented Apr 7, 2020

a8ci18n Apr 7, 2020

millerf commented Apr 7, 2020

Aurorum commented Apr 7, 2020

gwwar commented Apr 7, 2020 •

edited

Loading

akirk Apr 7, 2020

akirk Apr 13, 2020

Aurorum Apr 13, 2020

millerf commented Apr 8, 2020 •

edited

Loading

sixhours commented Apr 8, 2020

gwwar commented Apr 8, 2020

lcollette commented Apr 9, 2020

mmtr commented Apr 10, 2020

gwwar commented Apr 10, 2020

mmtr commented Apr 13, 2020 •

edited

Loading

a8ci18n Apr 13, 2020

Aurorum commented Apr 13, 2020

mmtr left a comment •

edited

Loading

mmtr commented Apr 14, 2020

Posts: Improve Clarity of Scheduled Time #40843

Posts: Improve Clarity of Scheduled Time #40843

Conversation

Aurorum commented Apr 7, 2020 • edited Loading

Changes proposed in this Pull Request

Testing instructions

a8ci18n Apr 7, 2020

Choose a reason for hiding this comment

sixhours commented Apr 7, 2020 • edited Loading

Aurorum commented Apr 7, 2020

a8ci18n Apr 7, 2020

Choose a reason for hiding this comment

millerf commented Apr 7, 2020

Aurorum commented Apr 7, 2020

gwwar commented Apr 7, 2020 • edited Loading

akirk Apr 7, 2020

Choose a reason for hiding this comment

akirk Apr 13, 2020

Choose a reason for hiding this comment

Aurorum Apr 13, 2020

Choose a reason for hiding this comment

millerf commented Apr 8, 2020 • edited Loading

sixhours commented Apr 8, 2020

gwwar commented Apr 8, 2020

lcollette commented Apr 9, 2020

mmtr commented Apr 10, 2020

gwwar commented Apr 10, 2020

mmtr commented Apr 13, 2020 • edited Loading

a8ci18n Apr 13, 2020

Choose a reason for hiding this comment

Aurorum commented Apr 13, 2020

mmtr left a comment • edited Loading

Choose a reason for hiding this comment

mmtr commented Apr 14, 2020

Aurorum commented Apr 7, 2020 •

edited

Loading

sixhours commented Apr 7, 2020 •

edited

Loading

gwwar commented Apr 7, 2020 •

edited

Loading

millerf commented Apr 8, 2020 •

edited

Loading

mmtr commented Apr 13, 2020 •

edited

Loading

mmtr left a comment •

edited

Loading