Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves existing devDependencies to dependencies #40880

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Apr 8, 2020

Changes proposed in this Pull Request

  • Moves devDependencies into dependencies. This is a pre-requisite to moving to yarn.

Testing instructions

Checkout the branch and do a diff of package-lock.json against master. Use grep to remove irrelevant bits (lots of changes in dev: true and extra commas for integrity). For example:

git diff -U0 master.. -- package-lock.json | grep -v '"dev": true' | grep -v '@@ '| grep  -v '"integrity"' | grep -v '"resolved"'

The result should show any effective change in the dependency tree. You'll see there are very few changes, all caused by applying different hoisting rules to wp-prettier@1.19.1 and is-number

@scinos scinos requested a review from a team as a code owner April 8, 2020 07:40
@matticbot
Copy link
Contributor

@scinos scinos requested a review from sirreal April 8, 2020 07:40
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos self-assigned this Apr 8, 2020
@scinos scinos added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 8, 2020
@scinos scinos added this to the Migration to yarn milestone Apr 8, 2020
@griffbrad griffbrad removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 8, 2020
@scinos scinos merged commit c9a8c34 into master Apr 8, 2020
@scinos scinos deleted the update/devdeps-to-deps branch April 8, 2020 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants