-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assert the correct package manager is used for run commands #40893
Conversation
"sync:blog-posts-block": "./bin/sync-blog-posts-block.sh", | ||
"wpcom-sync": "./bin/wpcom-watch-and-sync.sh", | ||
"prepare": "npm run sync:blog-posts-block --nodemodules" | ||
"full-site-editing": "check-npm-client && calypso-build --source='dotcom-fse'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these changes would be so much cleaner if package.json had support for prerun
... oh well 🤷♂
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
34b6664
to
97dee66
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢LGTM
d14c2b2
to
06540cc
Compare
Changes proposed in this Pull Request
This is part of yarn migration (see #40882). Once we have migrated in yarn and we are confident that everybody is used to the change, we can remove these guards.
Testing instructions
npm run...
commands. Everything should work fine.yarn run...
. You should see the error "please use npm instead of yarn"