Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs to use yarn in examples #40916

Merged
merged 2 commits into from
Apr 14, 2020

Conversation

scinos
Copy link
Contributor

@scinos scinos commented Apr 8, 2020

Changes proposed in this Pull Request

  • Updates README and other docs to use yarn commands instead of npm
  • Adds a new doc docs/dependency-management.md with the instructions to handle packages and workspaces in the repo.

Testing instructions

Nothing

@scinos scinos requested a review from a team as a code owner April 8, 2020 13:33
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Caution: This PR affects files in the FSE Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D41579-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2

@scinos scinos changed the base branch from master to update/npm-to-yarn-main April 8, 2020 13:38
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@griffbrad griffbrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢LGTM

@scinos scinos force-pushed the update/npm-to-yarn-docs branch 3 times, most recently from 47e968c to 2ca86f9 Compare April 13, 2020 23:01
@scinos scinos merged commit eade0fd into update/npm-to-yarn-main Apr 14, 2020
@scinos scinos deleted the update/npm-to-yarn-docs branch April 14, 2020 20:45
scinos added a commit that referenced this pull request Apr 16, 2020
* Update docs to use yarn in examples

* Undo accidental change in CREDITS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants