New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Cloud: Create ActivityCardList component and integrate into backups #40930
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~248 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
I am having a hard time reviewing the PR. Thing that would help are
I never managed to see a filter bar :(
Going to This also happends after I click on the Search icon and refresh the page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works as expected. I've selected a range, and I was able to see the list of the activities in that range. I found minor style issues in the DatePicker component when we select the 'to' date, but we can fix all the styles issues in other PR.
I left some comments
@@ -183,7 +181,7 @@ class BackupsPage extends Component { | |||
siteSlug={ siteSlug } | |||
/> | |||
|
|||
<div>{ isLoadingBackups && 'Loading backups...' }</div> | |||
<div>{ isLoadingBackups && translate( 'Loading backups…' ) }</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message was temporal. We could remove it and substitute it with a better design while we are waiting as Calypso does in other sections.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3203789 Hi @rcoll, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Testing instructions