Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Cloud: Create ActivityCardList component and integrate into backups #40930

Merged
merged 1 commit into from Apr 9, 2020

Conversation

rcoll
Copy link
Member

@rcoll rcoll commented Apr 8, 2020

Changes proposed in this Pull Request

  • This PR creates a new component to replace the Activity List on the main backups page. The new component is easily reusable and will be integrated into several other places that this list is utilized.
  • Also ... translate a few strings that were not done earlier

Testing instructions

  • Load up the main backups page, and click the calendar icon at the top to select a date range. Once you select a range, the view should switch to a list of activity cards.
  • Play with the filterbar. Does everything work as expected? Great!

@rcoll rcoll added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com) labels Apr 8, 2020
@rcoll rcoll requested review from cbauerman and cleacos April 8, 2020 19:37
@rcoll rcoll self-assigned this Apr 8, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~248 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
backups      +1071 B  (+0.3%)     +248 B  (+0.3%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@enejb
Copy link
Member

enejb commented Apr 9, 2020

I am having a hard time reviewing the PR. Thing that would help are

  • Screnshots what am I supposed be looking for.
  • What URL so I start at?
    I am not sure how to know if things look correct or not.

I never managed to see a filter bar :(
I also saw the following error

TypeError: siteCapabilities.includes is not a function

Going to http://jetpack.cloud.localhost:3000/activity/example.com produced a 404 page?
Is that still expected?

This also happends after I click on the Search icon and refresh the page.

Copy link
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected. I've selected a range, and I was able to see the list of the activities in that range. I found minor style issues in the DatePicker component when we select the 'to' date, but we can fix all the styles issues in other PR.

I left some comments

@@ -183,7 +181,7 @@ class BackupsPage extends Component {
siteSlug={ siteSlug }
/>

<div>{ isLoadingBackups && 'Loading backups...' }</div>
<div>{ isLoadingBackups && translate( 'Loading backups…' ) }</div>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message was temporal. We could remove it and substitute it with a better design while we are waiting as Calypso does in other sections.

@rcoll rcoll merged commit 0223f59 into master Apr 9, 2020
@rcoll rcoll deleted the add/jetpack-cloud-activity-list branch April 9, 2020 19:21
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2020
@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3203789

Hi @rcoll, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Find a backup or restore point
  • This is the complete event history for your site. Filter by date range and/ or activity type.

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented May 26, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jetpack Cloud Anything related to the Jetpack Cloud (cloud.jetpack.com)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants