New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Easter closure notices for Chat and Quick Start #40989
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Webpack Runtime (~66 bytes added 📈 [gzipped])
Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded. App Entrypoints (~13 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~1825 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1104 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -13,7 +13,10 @@ import ContactFormNotice from 'me/help/contact-form-notice/index'; | |||
import { useLocalizedMoment } from 'components/localized-moment'; | |||
|
|||
const DATE_FORMAT = 'LLL'; | |||
const translate = useTranslate(); | |||
|
|||
export const easterHolidayName = translate( 'Easter', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 145 times:
translate( 'Easter' )
ES Score: 17
ℹ️ This string already exists without a context. Only add a context if the meaning of the string is very specific.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3203778 Hi @mattwondra, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Shows Easter closure notices in Live Chat and Quick Start.
Testing instructions
Go to http://calypso.localhost:3000/help/contact:
Go to http://calypso.localhost:3000/me/concierge and pick a site:
Fixes 783-gh-hg 784-gh-hg