Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Easter closure notices for Chat and Quick Start #40989

Merged
merged 2 commits into from Apr 9, 2020

Conversation

mattwondra
Copy link
Member

@mattwondra mattwondra commented Apr 9, 2020

Changes proposed in this Pull Request

Shows Easter closure notices in Live Chat and Quick Start.

Testing instructions

Go to http://calypso.localhost:3000/help/contact:

  • The existing "Limited chat availability" notice should show
  • Set your computer's clock to April 12 at 0:00 UTC — the "Live chat will be closed for Easter" notice should show
  • Set your computer's clock to April 12 at 6:00 UTC — the "Live chat closed for Easter" notice should show
  • Set your computer's clock to April 13 at 6:00 UTC — the "Limited chat availability" notice should be back up

Go to http://calypso.localhost:3000/me/concierge and pick a site:

  • The "Note: Quick Start sessions will be closed for Easter..." notice should show
  • Set your computer's clock to April 12 at 6:00 UTC — the "Note: Quick Start sessions are closed for Easter..." notice should show
  • Set your computer's clock to April 13 at 6:00 UTC — the notices should be gone

Fixes 783-gh-hg 784-gh-hg

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~66 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
manifest       +621 B  (+0.4%)      +66 B  (+0.2%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~13 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main       +120 B  (+0.0%)      +13 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~1825 bytes added 📈 [gzipped])

name       parsed_size           gzip_size
help           +2067 B  (+0.4%)    +1097 B  (+0.9%)
concierge      +1335 B  (+0.5%)     +728 B  (+1.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~1104 bytes added 📈 [gzipped])

name                                   parsed_size           gzip_size
async-load-blocks-inline-help-popover      +2067 B  (+0.9%)    +1097 B  (+1.9%)
async-load-blocks-inline-help               +120 B  (+0.2%)       +7 B  (+0.1%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@mattwondra mattwondra added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] Blocked / Hold labels Apr 9, 2020
@@ -13,7 +13,10 @@ import ContactFormNotice from 'me/help/contact-form-notice/index';
import { useLocalizedMoment } from 'components/localized-moment';

const DATE_FORMAT = 'LLL';
const translate = useTranslate();

export const easterHolidayName = translate( 'Easter', {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 145 times:
translate( 'Easter' ) ES Score: 17

ℹ️ This string already exists without a context. Only add a context if the meaning of the string is very specific.

@mattwondra mattwondra merged commit aa18b53 into master Apr 9, 2020
@mattwondra mattwondra deleted the update/add-easter-closure-notices branch April 9, 2020 18:48
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2020
@a8ci18n
Copy link

a8ci18n commented May 22, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3203778

Hi @mattwondra, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Easter

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented May 26, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants