Enhance/display important dates on search #41242

millerf · 2020-04-18T10:46:50Z

Changes proposed in this Pull Request

Depending on post/page status, display the most meaningful date
On search, display the said date with the status label
~~Small~~ Good Refactor of PostRelativeTime

Search results should look close to this mockup:

Testing instructions

Go to pages or posts views. Make sure displayed dates are the right ones
When searching, make sure the dates are the same and label is displayed

Extras

Found a bug reported here
#41245
As it is out of scope for this one.

Fixes #41075

cc @mmtr @sixhours

Added "sticky" status for posts on search and listing

Add sticky Label for posts

a8ci18n · 2020-04-18T17:21:24Z

client/my-sites/post-relative-time-status/index.jsx

-		return time.fromNow();
+		// If the content is scheduled to be release within a year, do not display the year at the end
+		const scheduledTime = scheduledDate.calendar( null, {
+			sameElse: this.props.translate( '[on] ll [at] LT', {


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 20 times:
translate( 'LL [at] LT' ) ES Score: 7
See 1 additional suggestions in the PR translation status page

'LL [at] LT' has been modified and is now '[on] ll [at] LT'

a8ci18n · 2020-04-18T17:21:25Z

client/my-sites/post-relative-time-status/index.jsx

-				statusText = this.props.translate( 'Publish immediately' );
-			}
+			const displayScheduleTime = this.getDisplayedTimeForLabel();
+			statusText = this.props.translate( 'scheduled %(displayScheduleTime)s', {


ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 3 times:
translate( 'scheduled for %(displayScheduleTime)s' ) ES Score: 8

'scheduled for %(displayScheduleTime)s' has been modified and is now 'scheduled %(displayScheduleTime)s'

millerf · 2020-04-18T17:33:54Z

PostRelativeTime was refactored.

Posts and Pages views were modified according to specs:

Before	After	Comment
		On listing, scheduled posts/pages now display the right date (scheduled ate)
		Published now display "sticky" if needed
		Post Search now displays the right status and appropriate date. The "sticky" status has been added. Maybe need some feedback from design?
		Pages search now displays only one date and the right status

…ow (Automattic#41129) * initial commit: - adding methods for start and end - adding a constant for the flow name (could also be used for API calls, e.g., sites/new) * refactored the start and complete to use a method with a default flow id Changed the `gutenboarding` signup start track id with `calypso_signup_step_enter` * Adding calypso_signup_complete tracking with new site and new user props. The current signup framework also passes `hasCartItems`, but I think we'll need a way to store that before we can pass it given that we do a redirect to the checkout * Fix linting issue, add newUser to Header useEffect dependency array * Update client/landing/gutenboarding/utils/analytics.ts Correct jsdoc usage comment Co-Authored-By: roo2 <roo2@users.noreply.github.com> * Remove useless comment. * Moved analytics from /utils to /lib/analytics as utils seem to contain pure functions/no side effects. We can think about where to put analytics later, and whether to add to a store for easier testing similar to the Calypso analytics actions Co-authored-by: Andrew Serong <andrewserong@users.noreply.github.com> Co-authored-by: roo2 <roo2@users.noreply.github.com>

)

…1271)

* Add suffix to railcar identifier * Shift the railcar identifier logic up one level

…1264) * Include the site id in `calypso_signup_complete` event. Per request by p2-pau2Xa-12j, this commit adds the site id to `calypso_signup_complete` event. In the same vein, `isNewSite` becomes a derived data within the function itself, hence removing it from the call sites. * Update `site_id` as `blog_id` since the latter is what Tracks expects.

* Modularise login state * Create directory for login actions * Split out remoteLoginUser * Split out loginUser * Split out updateNonce * Split out loginUserWithSecurityKey * Split out loginUserWithTwoFactorVerificationCode * Split out loginSocialUser * Fix bad imports * Split out createSocialUser * Split out connectSocialUser * Split out disconnectSocialUser * Split out createSocialUserFailed * Split out sendSmsCode * Split out push-related actions * Split out account type-related actions * Split out formUpdate * Sort exports alphabetically * Reorganise 2fa push poll code * Remove unnecessary auth-options inits * Fix addReducer on login entry point * Extract addReducerEnhancer into a util

)

…and DNS (Automattic#41019) Show the destination of a domain - does it point to WordPress.com site or is external - in the "Change your name servers & DNS records" nav item

* Rework Selectors as class to manage `vendor` * Provide suggestions vendor to store registration

* Jetpack Cloud: Scanner display threats * Fixes issues with typing. * Adds threat type parser. * Cleans up unused code and adds handling for idle state. * Moves some logic to description component. * Fixes style bugs with spacing. * Adds typing for threat fixing. * Adds logic around fixers and additional typing. * Fixes position of fixing buttons on mobile. * Fix buttons layout on mobile Co-authored-by: Echo G <ChaosExAnima@users.noreply.github.com> Co-authored-by: Renzo Canepa <rcanepag@gmail.com>

* Add Earth Day Live setting toggle to settings * Add moment import * Update copy as per editorial feedback

sixhours · 2020-04-20T15:25:09Z

Thanks @millerf ! It looks like this needs to be rebased, it's asking me to use npm when we recently switched to yarn. Give that a try and let us know if you need help with it!

Added "sticky" status for posts on search and listing

Add sticky Label for posts

…ithub.com/millerf/wp-calypso into enhance/display_important_dates_on_search

sixhours

This is not a comprehensive review. Please disregard if this is still "in progress"!

I noticed a couple issues when I fired this up:

When searching posts, the date shows "Published modified on [date]":

When searching for a scheduled post, the line "Scheduled for Tomorrow at [time]" reads oddly because "tomorrow" is capitalized:

The latter issue isn't unique to this PR (I noticed the same behavior on prod) but might be something we could address. Totally OK if that's out of scope and we address in a different PR: let me know and I'll create an issue.

sixhours · 2020-04-20T15:28:34Z

client/blocks/post-item/index.jsx

@@ -211,7 +211,7 @@ class PostItem extends React.Component {
 										post={ post }
 										link={ enabledPostLink }
 										target={ null }
-										gridiconSize={ ICON_SIZE }
+										gridIconSize={ ICON_SIZE }


Minor, but gridiconSize is correct, as Gridicon is one word: https://github.com/Automattic/gridicons

Damn... I tried to look smart... 😄

sixhours · 2020-04-20T15:28:48Z

client/my-sites/pages/page-card-info/index.jsx

@@ -62,7 +62,7 @@ function PageCardInfo( {
 						post={ page }
 						link={ contentLink.contentLinkURL }
 						target={ contentLink.contentLinkTarget }
-						gridiconSize={ ICON_SIZE }
+						gridIconSize={ ICON_SIZE }


Same here re: Gridicon

I'll revert the commit

sixhours · 2020-04-20T15:29:01Z

client/my-sites/post-relative-time-status/index.jsx

 		link: PropTypes.string,
 		target: PropTypes.string,
-		gridiconSize: PropTypes.number,
+		gridIconSize: PropTypes.number,


resolved on #41301

millerf · 2020-04-20T16:54:16Z

"Published modified on [date]"

I see. What would be the correct way to say it... the idea is that the status of the post is published but the date is the last modified date.
Would "Published, last modified on [date]" be acceptable?

"Scheduled for Tomorrow at [time]"

It is definitely in the scope. I'll fix it.

I am having some trouble to push since I rebased. I don't think it is linked to the rebase, as I seem to have the same trouble on new branches...

refusing to allow an OAuth App to create or update workflow `.github/workflows/full-site-editing-plugin.yml` without `workflow` scope

So not sure if I would be able to address all that tonight.

sixhours · 2020-04-20T17:01:17Z

Would "Published, last modified on [date]" be acceptable?

Yes, that sounds right to me!

It is definitely in the scope. I'll fix it.

Yay! Thank you!

I am having some trouble to push since I rebased. I don't think it is linked to the rebase, as I seem to have the same trouble on new branches...

That's a new one to me. 😬 It sounds like something weird with Git/Github? Hoping @kwight can offer some insight.

millerf · 2020-04-20T17:07:55Z

It sounds like something weird with Git/Github? Hoping @kwight can offer some insight.

It is bizarre as I am pushing on my fork... Also using command-line. All help I found online relate to git GUIs... I might just scratch the local repo...

sixhours · 2020-04-20T17:13:27Z

I might just scratch the local repo...

That's my go-to for fixing weirdness, too. Burn it all to the ground. :D

millerf · 2020-04-20T18:10:32Z

I might just scratch the local repo...

That's my go-to for fixing weirdness, too. Burn it all to the ground. :D

Wow... I deleted the local repo, updated git, nothing worked. I ended up downloading Github Desktop and it worked straight away... Something about OAuth tokens that weren't saved the right way or something. Github desktop manages it in the automatically in the background and it worked...

millerf · 2020-04-20T20:39:09Z

Work continues on #41301

millerf added 2 commits April 18, 2020 12:42

Display the right date all the time

b88ed08

Small refactor as post cannot be null (props.isRequired)

cf87b92

matticbot added the OSS Citizen label Apr 18, 2020

millerf added 4 commits April 18, 2020 12:50

clean up - includeNonDraftStatuses was never used across the project

0b14e9d

Fix CamelCase

cee0699

More refactor.

e4a9c69

Added "sticky" status for posts on search and listing

Refactor label, use only one method to display time label

f606315

Add sticky Label for posts

millerf changed the title ~~WIP: Enhance/display important dates on search~~ Enhance/display important dates on search Apr 18, 2020

a8ci18n reviewed Apr 18, 2020

View reviewed changes

ramonjd and others added 2 commits April 20, 2020 12:01

Project: Remove arg forwarding "--" from yarn commands (Automattic#41263

ed07939

)

mmtr requested a review from a team April 20, 2020 09:00

mmtr assigned millerf Apr 20, 2020

mmtr added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 20, 2020

Aurorum and others added 14 commits April 20, 2020 11:07

Customer Home: Updating Timing of Connect Accounts Task (Automattic#4…

705fb90

…1271)

Add suffix to railcar identifier (Automattic#41197)

3ab1d51

* Add suffix to railcar identifier * Shift the railcar identifier logic up one level

Enable private atomic sites for 5% of new users (Automattic#40846)

05c7e93

Jetpack: Add scan to the connect page (Automattic#41180)

73d0d63

Async load 2FA login code (Automattic#41223)

d1c97c1

Domains: Extend primary domain restriction to mappings (Automattic#41139

2537bdc

)

Show the destination in the domains navigation item for name servers …

a11e8e8

…and DNS (Automattic#41019) Show the destination of a domain - does it point to WordPress.com site or is external - in the "Change your name servers & DNS records" nav item

Remove old domain status components (Automattic#41196)

baa8ac0

Upgrade to wp-prettier 2.0.4

1f228c2

Automatic reformat with yarn reformat-files

4537033

Data-stores: Provide domain suggestions vendor (Automattic#41177)

4ee36be

* Rework Selectors as class to manage `vendor` * Provide suggestions vendor to store registration

Add Earth Day Live setting (Automattic#41275)

043153e

* Add Earth Day Live setting toggle to settings * Add moment import * Update copy as per editorial feedback

millerf added 7 commits April 20, 2020 17:49

Display the right date all the time

338684d

Small refactor as post cannot be null (props.isRequired)

4b905be

clean up - includeNonDraftStatuses was never used across the project

8c92772

Fix CamelCase

45b9605

More refactor.

19176be

Added "sticky" status for posts on search and listing

Refactor label, use only one method to display time label

1bb511b

Add sticky Label for posts

Merge branch 'enhance/display_important_dates_on_search' of https://g…

525b73c

…ithub.com/millerf/wp-calypso into enhance/display_important_dates_on_search

sixhours reviewed Apr 20, 2020

View reviewed changes

millerf requested review from oandregal and a team as code owners April 20, 2020 18:08

millerf closed this Apr 20, 2020

millerf deleted the enhance/display_important_dates_on_search branch April 20, 2020 18:14

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 20, 2020

millerf mentioned this pull request Apr 20, 2020

Enhance/display important dates on search #41301

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance/display important dates on search #41242

Enhance/display important dates on search #41242

millerf commented Apr 18, 2020 •

edited

Loading

a8ci18n Apr 18, 2020

millerf Apr 18, 2020

a8ci18n Apr 18, 2020

millerf Apr 18, 2020

millerf commented Apr 18, 2020

sixhours commented Apr 20, 2020

sixhours left a comment •

edited

Loading

sixhours Apr 20, 2020

millerf Apr 20, 2020

sixhours Apr 20, 2020

millerf Apr 20, 2020

sixhours Apr 20, 2020

millerf Apr 20, 2020

millerf commented Apr 20, 2020

sixhours commented Apr 20, 2020

millerf commented Apr 20, 2020

sixhours commented Apr 20, 2020

millerf commented Apr 20, 2020

millerf commented Apr 20, 2020

Enhance/display important dates on search #41242

Enhance/display important dates on search #41242

Conversation

millerf commented Apr 18, 2020 • edited Loading

Changes proposed in this Pull Request

Testing instructions

Extras

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

millerf commented Apr 18, 2020

sixhours commented Apr 20, 2020

sixhours left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

millerf commented Apr 20, 2020

sixhours commented Apr 20, 2020

millerf commented Apr 20, 2020

sixhours commented Apr 20, 2020

millerf commented Apr 20, 2020

millerf commented Apr 20, 2020

millerf commented Apr 18, 2020 •

edited

Loading

sixhours left a comment •

edited

Loading