Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance/display important dates on search #41301
Enhance/display important dates on search #41301
Changes from 10 commits
e5611f3
3cee3d4
d676b2e
36be7c5
5ca266b
38dc57d
32b2d1b
1434be6
aca3eb5
3f0bb96
2ed0eed
7be3d67
31323cb
dc7e183
75cafee
964df20
00c3126
a05f2fe
75965c2
20c0305
6157493
e651d84
db74c42
cb7b07d
5defad5
6b0fcda
effba2a
edd82c6
0380076
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Automattic/i18n or @akirk can confirm, but I think we need to handle both status and date on the same translation. For instance, here
displayScheduleTime
containson [date]
for posts trashed more than a week ago, sotrashed %(displayScheduleTime)s
finally reads astrashed on [date]
. Some languages might need to move the translated "on" part before "trashed" (while leaving the date after). To support those languages, the translatable string should betrashed on [date]
rather thantrashed [datePrefixedWithOn]
.The same applies for the rest of statuses (scheduled for [date], published on [date], draft last modified on [date], ...).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite complex to tackle, as the "on" is not always present (for example : "Published yesterday" vs "Published on Mar, 23 march 2020")
And as translation texts cannot have variables to pass on the status, I would have to have to list all cases that could happen.
Also waiting to translators to confirm, but I think the "on" is the beginning of the proposition of time, so it correlates more with the date than the adjective. As in "On 23rd of March, I published, etc,..." But I might be mistaken...