Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordAds: Add configuration settings for California Consumer Privacy Act (CCPA) #41651

Merged
merged 1 commit into from May 18, 2020

Conversation

cphilleo
Copy link
Contributor

@cphilleo cphilleo commented Apr 30, 2020

Changes proposed in this Pull Request

  • Adds configuration settings for California Consumer Privacy Act (CCPA) for WordAds sites

Testing instructions

  • Create or choose a WordAds enabled site on a Premium or Personal plan
  • Navigate to the Ads Dashboard -> Settings screen
  • Verify you can enable/disable the CCPA option
  • Verify you can enter/remove the site privacy policy URL

@matticbot
Copy link
Contributor

</FormFieldset>
<FormFieldset>
<FormLabel htmlFor="ccpa-privacy-policy-url">
{ translate( 'Privacy Policy URL' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 111 times:
translate( 'Privacy Policy' ) ES Score: 6
See 2 additional suggestions in the PR translation status page

@matticbot
Copy link
Contributor

matticbot commented Apr 30, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1140 bytes added 📈 [gzipped])

name  parsed_size           gzip_size
earn      +4472 B  (+1.8%)    +1140 B  (+1.8%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rclations rclations left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, and I don't think we should hold up launching it.


Screen Shot 2020-05-01 at 1 50 24 PM

Two things I'm struggling with in the UI:

  1. "Do Not Sell" instructions are a big wall of text. It's hard to make myself read through all of this - would be great if we could find a way to break it up or make the display more digestible.

  2. It's hard to notice that the Privacy Policy URL is optional.

client/my-sites/site-settings/jetpack-ads.jsx Outdated Show resolved Hide resolved
client/my-sites/earn/ads/form-settings.jsx Outdated Show resolved Hide resolved
client/my-sites/earn/ads/form-settings.jsx Outdated Show resolved Hide resolved
client/my-sites/site-settings/jetpack-ads.jsx Outdated Show resolved Hide resolved
@cphilleo cphilleo force-pushed the add/wordads-ccpa branch 3 times, most recently from c19dc1e to 68a9430 Compare May 16, 2020 00:05

<FormFieldset>
<FormLabel htmlFor="ccpa-privacy-policy-url">
{ translate( 'Privacy Policy URL' ) }
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 93 times:
translate( 'privacy-policy' ) ES Score: 6
See 2 additional suggestions in the PR translation status page

@cphilleo cphilleo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge and removed [Status] In Progress [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 18, 2020
@cphilleo cphilleo merged commit 22720a7 into master May 18, 2020
@cphilleo cphilleo deleted the add/wordads-ccpa branch May 18, 2020 21:07
@a8ci18n
Copy link

a8ci18n commented May 18, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3627533

Hi @cphilleo, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • Privacy and Consent
  • Enables a targeted advertising opt-out link for California consumers, as required by the California Consumer Privacy Act (CCPA).
  • Enable targeted advertising to California site visitors (CCPA)
  • For more information about the California Consumer Privacy Act (CCPA) and how it pertains to your site, please consult our {{a}}CCPA guide for site owners{{/a}}.
  • Do Not Sell Link
  • CCPA requires that you place a "Do Not Sell My Personal Information" link on every page of your site where targeted advertising will appear. You can use the {{a}}Do Not Sell Link (CCPA) Widget{{/a}}, or the {{code}}[ccpa-do-not-sell-link]{{/code}} shortcode to automatically place this link on your site. Note: the link will always display to logged in administrators regardless of geolocation.
  • Failure to add this link will result in non-compliance with CCPA.
  • Privacy Policy URL
  • Adds a link to your privacy policy to the bottom of the CCPA notice popup (optional).

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented May 28, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants