New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WordAds: Add configuration settings for California Consumer Privacy Act (CCPA) #41651
Conversation
</FormFieldset> | ||
<FormFieldset> | ||
<FormLabel htmlFor="ccpa-privacy-policy-url"> | ||
{ translate( 'Privacy Policy URL' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 111 times:
translate( 'Privacy Policy' )
ES Score: 6
See 2 additional suggestions in the PR translation status page
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1140 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks great, and I don't think we should hold up launching it.
Two things I'm struggling with in the UI:
-
"Do Not Sell" instructions are a big wall of text. It's hard to make myself read through all of this - would be great if we could find a way to break it up or make the display more digestible.
-
It's hard to notice that the Privacy Policy URL is optional.
c19dc1e
to
68a9430
Compare
|
||
<FormFieldset> | ||
<FormLabel htmlFor="ccpa-privacy-policy-url"> | ||
{ translate( 'Privacy Policy URL' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 93 times:
translate( 'privacy-policy' )
ES Score: 6
See 2 additional suggestions in the PR translation status page
68a9430
to
e5c7697
Compare
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3627533 Hi @cphilleo, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
Testing instructions