Fix the styles of Jetpack Cloud Settings section

[cleacos]

Changes proposed in this Pull Request

Fix a few styles of the Jetpack Cloud Settings section:

Asana Card: 1142395350490785-as-1173118334902107

• Set the title font with the correct size
• Added the expected icons for connected and disconnected server status. Align it to the center.
• Fixed a line jump on disconnected status
• Added loading block with pulse effect

I copied completely the RewindCredentialsForm component from Calypso to be able to change styles and the icon position. Also, this allows us to have control of the design.

Before

Now

Loading block:

The expected icons, centered:

Testing instructions

• Apply these changes
• Check if the design match with the expected

[matticbot]

Test live: https://calypso.live/?branch=fix/jetpack-cloud-setting-page-design-tweak

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime (~71 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
manifest       +291 B  (+0.2%)      +71 B  (+0.2%)

Webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

App Entrypoints (~43 bytes removed 📉 [gzipped])

name        parsed_size           gzip_size
entry-main        -55 B  (-0.0%)      -43 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~779 bytes added 📈 [gzipped])

name                    parsed_size           gzip_size
scan                         +674 B  (+0.4%)    +1061 B  (+2.2%)
jetpack-cloud-settings       -379 B  (-0.4%)     -274 B  (-0.9%)
signup                        -64 B  (-0.0%)       -8 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[rcanepa]

@cleacos , we have a HOC that gives you all the functionality you to make this form work. It lets you define any UI for the form without worrying about the functionality (this HOC will give you everything by prop).

Here is the component: https://github.com/Automattic/wp-calypso/blob/master/client/landing/jetpack-cloud/components/with-server-credentials-form/index.jsx

And here is an example of how you can use it: https://github.com/Automattic/wp-calypso/blob/master/client/landing/jetpack-cloud/components/server-credentials-form/index.jsx

^ Notice how we the ServerCredentialsForm is wrapped by the withServerCredentialsForm HOC.

In short, if we reuse that component, we could remove the logic part of this new form.

[cleacos]

@rcanepa thank you for showing me the existing component. But I'll need to update that component for this case, this is for a section so we don't need the Cancel button and also I'll ask Yvonne about the design, basically about the hidden options and if the Save credentials button is okay like that.

[rcanepa]

@cleacos I don't think you need to modify anything for that reason. If you only use the withServerCredentialsForm HOC you can keep your component UI and remove the logic you copied. In other words, you need to implement your own ServerCredentialsForm (this is only UI) and wrap it with the withServerCredentialsForm HOC.

[a8ci18n]

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 18 times:
translate( 'Save credentials and fix' ) ES Score: 7

[rcanepa]

LGTM!

The next iteration could include using a placeholder for the whole form while the credentials are being fetched or we could disable the inputs while that is happening.