Signup form: Accept a custom "handleLogin" function prop

[DanReyLop]

Changes proposed in this Pull Request

In d9c6ba4, make the WooCommerce version of the SignupForm block respect the footerLink prop. That prop already existed, but was only being used in the other branches of the SignupForm block, here and here.

In 92d2cc0, added an optional handleLogin prop to the SignupForm block. This function, if it exists, will be called when the "login" link is clicked, instead of making a full-page redirect to the login form.

How to test

This is just a refactor, there shouldn't be any regression. At this moment, SignupForm is never called with a handleLogin prop, nor is called with a custom footerLink on the WooCommerce flow.

Note: This is a required refactor for the new "Woo DNA" flow, implemented in #41798

[matticbot]

Test live: https://calypso.live/?branch=woodna/signup-block-enhancements

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login        +41 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~100 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +193 B  (+0.0%)      +50 B  (+0.0%)
accept-invite         +193 B  (+0.1%)      +50 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~53 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user       +193 B  (+0.2%)      +50 B  (+0.2%)
async-load-design-blocks            +41 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[vbelolapotkov]

@DanReyLop the changes look good and straightforward. Do you have any idea why ci/wp-desktop check fails?

[vbelolapotkov]

I've taken a look at the checks in this commit d9c6ba4 and see ci/wp-desktop was passing. I doubt the following commit with style fixing is causing it to fail, so go to go IMO.

[DanReyLop]

I've taken a look at the checks in this commit d9c6ba4 and see ci/wp-desktop was passing. I doubt the following commit with style fixing is causing it to fail, so go to go IMO.

Thanks for investigating! You're right, the wp-desktop failure is probably unrelated.

I'll wait to merge this until I have a bunch of them to merge, there's going to be a lot of Git gardening involved and the more times I need to do it, the more possibilities of messing it up.