Jetpack Authorize component: minor refactor

[DanReyLop]

Changes proposed in this Pull Request

In bd918e5, removed the isAtomic prop since it wasn't being used.

In 5717ba9, extracted the rendering of the "Back to WP-Admin" link into a separate function.

How to test

While logged into WordPress.com, connect to Jetpack from your local site. This link should still work:

Note: This is a required refactor for the new "Woo DNA" flow, implemented in #41798

[matticbot]

Test live: https://calypso.live/?branch=woodna/jetpack-authorize-refactor

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login        +41 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~136 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +247 B  (+0.0%)      +86 B  (+0.1%)
accept-invite         +193 B  (+0.1%)      +50 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~53 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user       +193 B  (+0.2%)      +50 B  (+0.2%)
async-load-design-blocks            +41 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[vbelolapotkov]

LGTM! Tested and it works as expected! 👍

[sgomes]

@Automattic/team-calypso: This PR only changes one file in jetpack-connect. Any idea why it pinged so many teams for a review?

[noahtallen]

@sgomes seems like a bad rebase?

[DanReyLop]

This is so weird. Is there any automation that adds team reviews depending on the files touched? It's possible that this PR was "massive" for a moment (I did some rebasing with multiple branches and pushed them in no particular order).

[noahtallen]

Yes and yes! The Code owners file adds review requests. I’ve often seen similar things happen when I get pinged for a review during a rebase. it doesn’t normally happen for simple rebase in master though. Working with lots of branches could do it though

[DanReyLop]

Oops, sorry about the noise then! This was definitely not a simple rebase. I'll be more careful about pushing branches in the correct order in the future.