-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an optional parameter to JetpackConnectHelpButton to link to a different URL #41804
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~6 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~167 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~49 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
1af1547
to
1f5969c
Compare
5751f65
to
94ce4c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
1f5969c
to
88f6e05
Compare
…o intercept the "is this you? log in" link
… the default footer links.
…neric "from" parameter
…e without any extra formatting
…ing "title" props
383c41a
to
e49a4dd
Compare
88f6e05
to
8191ede
Compare
Changes proposed in this Pull Request
When HappyChat is not available, the
JetpackConnectHelpButton
becomes a simple link that sends the user to'https://jetpack.com/contact-support'
. This PR makes that URL customizable.How to test
There's no code that calls
JetpackConnectHelpButton
with aurl
prop, so there's no way to test this. You can test there has been no regression by starting the Jetpack connection flow and clicking on the "(?) Get help setting up Jetpack" link.Note: This is a required refactor for the new "Woo DNA" flow, implemented in #41798