Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional parameter to JetpackConnectHelpButton to link to a different URL #41804

Merged
merged 13 commits into from
Jun 10, 2020

Conversation

DanReyLop
Copy link
Contributor

Changes proposed in this Pull Request

When HappyChat is not available, the JetpackConnectHelpButton becomes a simple link that sends the user to 'https://jetpack.com/contact-support'. This PR makes that URL customizable.

How to test

There's no code that calls JetpackConnectHelpButton with a url prop, so there's no way to test this. You can test there has been no regression by starting the Jetpack connection flow and clicking on the "(?) Get help setting up Jetpack" link.

Note: This is a required refactor for the new "Woo DNA" flow, implemented in #41798

@DanReyLop DanReyLop added Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 5, 2020
@DanReyLop DanReyLop requested a review from a team May 5, 2020 13:03
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented May 5, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
entry-login        +58 B  (+0.0%)      +10 B  (+0.0%)
entry-main         +17 B  (+0.0%)       -4 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~167 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
jetpack-connect       +295 B  (+0.1%)     +121 B  (+0.1%)
accept-invite         +166 B  (+0.1%)      +46 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~49 bytes added 📈 [gzipped])

name                          parsed_size           gzip_size
async-load-signup-steps-user       +166 B  (+0.1%)      +46 B  (+0.1%)
async-load-design-blocks            +41 B  (+0.0%)       +3 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@DanReyLop DanReyLop force-pushed the woodna/override-jetpack-help-url branch from 1af1547 to 1f5969c Compare May 5, 2020 15:33
@DanReyLop DanReyLop force-pushed the woodna/document-title-override branch from 5751f65 to 94ce4c2 Compare May 5, 2020 15:34
Copy link
Contributor

@vbelolapotkov vbelolapotkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@vbelolapotkov vbelolapotkov added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 2, 2020
@DanReyLop DanReyLop force-pushed the woodna/override-jetpack-help-url branch from 1f5969c to 88f6e05 Compare June 8, 2020 10:44
@DanReyLop DanReyLop force-pushed the woodna/document-title-override branch from 383c41a to e49a4dd Compare June 8, 2020 12:04
@DanReyLop DanReyLop force-pushed the woodna/override-jetpack-help-url branch from 88f6e05 to 8191ede Compare June 8, 2020 12:05
Base automatically changed from woodna/document-title-override to master June 9, 2020 22:07
@DanReyLop DanReyLop merged commit fcdc014 into master Jun 10, 2020
@DanReyLop DanReyLop deleted the woodna/override-jetpack-help-url branch June 10, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants