Gutenboarding: Plans grid HTML mockup. #41864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~1750 bytes added 📈 [gzipped]) Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
alshakero
approved these changes
May 6, 2020
client/landing/gutenboarding/onboarding-block/plans/plan-item.tsx
Outdated
Show resolved
Hide resolved
client/landing/gutenboarding/onboarding-block/plans/plan-item.tsx
Outdated
Show resolved
Hide resolved
client/landing/gutenboarding/onboarding-block/plans/plan-item.tsx
Outdated
Show resolved
Hide resolved
client/landing/gutenboarding/onboarding-block/plans/plan-item.tsx
Outdated
Show resolved
Hide resolved
simison
approved these changes
May 7, 2020
There was a problem hiding this comment.
Looks great here too. 👍 With applying @alshakero's notes we could merge this and iterate over it, and start connecting it to the canvas from #41857 and to data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
/new/plansto see the mockup.Fixes #41787