Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: plans - hide domain nudge #41991

Merged
merged 1 commit into from
May 8, 2020

Conversation

simison
Copy link
Member

@simison simison commented May 8, 2020

Until we move domains modal to a step-canvas or some other mechanics; let's hide the link for now. We'll add this back once rest of the plans grid is ready.

Changes proposed in this Pull Request

  • Hide domain nudge from the plans grid.

Testing instructions

  • In /new flow (on live sites with ?flags=gutenboarding/plans-grid) ...
  • Open the plans grid from plan button
  • Observe no domain nudge link
  • Choosing domain doesn't work yet, but you can set the prop manually and see it show up in every plan
Before

image

After

Screenshot 2020-05-08 at 17 09 59

Screenshot 2020-05-08 at 17 10 08

Until we move domains modal to a step-canvas or some other mechanics; let's hide the link for now. We'll
@simison simison added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Goal] New Onboarding previously called Gutenboarding labels May 8, 2020
@simison simison requested a review from a team May 8, 2020 14:47
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~30 bytes removed 📉 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding       -209 B  (-0.0%)      -30 B  (-0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@simison simison requested a review from a team May 8, 2020 15:23
@alshakero alshakero merged commit 169f7f6 into master May 8, 2020
@alshakero alshakero deleted the update/gutenborading-plans-domains branch May 8, 2020 19:28
Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants