Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenboarding: Show "Free Wordpress.com Subdomain" on plans grid for Free plan. #42045

Merged
merged 1 commit into from
May 11, 2020

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 11, 2020

Changes proposed in this Pull Request

While domain picker is disabled, show "Free Wordpress.com Subdomain" on plans grid for Free plan.

Testing instructions

  • Just open up plans grid in gutenboarding.

Screenshot

image

@yansern yansern added the [Goal] New Onboarding previously called Gutenboarding label May 11, 2020
@yansern yansern requested review from alshakero and a team May 11, 2020 12:49
@yansern yansern self-assigned this May 11, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~17 bytes added 📈 [gzipped])

name                 parsed_size           gzip_size
entry-gutenboarding        +44 B  (+0.0%)      +17 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@alshakero alshakero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested. LGTM.

@yansern yansern merged commit a7ec096 into master May 11, 2020
@yansern yansern deleted the update/gutenboarding-free-plan-subdomain-text branch May 11, 2020 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] New Onboarding previously called Gutenboarding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants