Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates wording of onboarding to specify VaultPress #42059

Merged
merged 1 commit into from
May 13, 2020

Conversation

ChaosExAnima
Copy link
Contributor

Changes proposed in this Pull Request

  • This updates the onboarding checklist to specify VaultPress instead of a more generic phrase, to avoid confusion with Jetpack Backup and Scan product.

Testing instructions

  • Set up a Jetpack site with a plan with VaultPress.
  • Go to Plan > My Plan.
  • Toggle the prop vaultpressFinished on the JetpackChecklist component and observe results.

Screenshots:
Screen Shot 2020-05-11 at 11 42 39 AM

Screen Shot 2020-05-11 at 11 42 49 AM

Fixes 1143508703416848-as-1174921179573827.

@ChaosExAnima ChaosExAnima added [Type] Bug Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Size] S Small sized issue [Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. labels May 11, 2020
@ChaosExAnima ChaosExAnima requested review from jeffgolenski and a team May 11, 2020 15:50
@ChaosExAnima ChaosExAnima self-assigned this May 11, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@mattgawarecki
Copy link
Contributor

I wasn't able to see the original behavior in production -- for some reason, it still shows my site as having "Backup & Scan" -- but I was able to verify the behavior in your screenshots on my local copy:

vaultpressFinished = true

image

vaultpressFinished = false

image

@jeffgolenski
Copy link
Member

Tested on one of @ChaosExAnima's test sites!

Per a slack convo, the VaultPress references look good.

My only concern is that the "try it" button CTA should not be displaying while we're auto activating VP. (which may be for another PR).

Thanks Echo!

@ChaosExAnima ChaosExAnima merged commit d4d9986 into master May 13, 2020
@ChaosExAnima ChaosExAnima deleted the fix/change-vp-checklist-wording branch May 13, 2020 16:13
@matticbot matticbot removed [Status] Needs Design Review Add this when you'd like to get a review / feedback from the Design team on your PR [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 13, 2020
@a8ci18n
Copy link

a8ci18n commented May 13, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3564890

Thank you @ChaosExAnima for including a screenshot in the description! This is really helpful for our translators.

@akirk
Copy link
Member

akirk commented May 13, 2020

^ Sorry, this is a bug. Translation will take some more time. The bot will update its message soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Signup & Site Onboarding Tools for user registration and onboarding new users to the site. Jetpack [Size] S Small sized issue [Type] Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants