Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update dependency eslint to v7 #42269

Merged
merged 2 commits into from May 22, 2020
Merged

chore(deps): update dependency eslint to v7 #42269

merged 2 commits into from May 22, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 15, 2020

This PR contains the following updates:

Package Type Update Change
eslint (source) peerDependencies major ^6.0.0 -> ^7.0.0
eslint (source) dependencies major ^6.8.0 -> ^7.0.0

Release Notes

eslint/eslint

v7.0.0

Compare Source

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner May 15, 2020 13:07
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=renovate/eslint-7.x

@matticbot
Copy link
Contributor

matticbot commented May 18, 2020 •
edited

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@scinos scinos self-assigned this May 20, 2020
@renovate
Copy link
Contributor Author

renovate bot commented May 20, 2020

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@scinos
Copy link
Contributor

scinos commented May 20, 2020

With eslint@6.0.0 we get ✖ 5699 problems (4587 errors, 1112 warnings)
With this new version we get ✖ 5707 problems (4595 errors, 1112 warnings)

The new errors are:

/Users/sergio/src/automattic/wp-calypso/client/landing/jetpack-cloud/components/with-server-credentials-form/test/index.js
  68:2  error  The members of 'actions' are read-only  no-import-assign
  71:2  error  The members of 'actions' are read-only  no-import-assign

/Users/sergio/src/automattic/wp-calypso/client/lib/checkout/test/validation.js
  165:5  error  The members of 'processorSpecificMethods' are read-only  no-import-assign
  168:5  error  The members of 'processorSpecificMethods' are read-only  no-import-assign
  244:5  error  The members of 'processorSpecificMethods' are read-only  no-import-assign

/Users/sergio/src/automattic/wp-calypso/client/state/data-layer/wpcom/sites/scan/test/index.js
  14:2  error  The members of 'wpcomHttpActions' are read-only  no-import-assign

/Users/sergio/src/automattic/wp-calypso/client/state/happychat/test/utils.js
  39:4  error  The members of 'selectedSite' are read-only  no-import-assign
  65:4  error  The members of 'selectedSite' are read-only  no-import-assign

@scinos scinos added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 20, 2020
@scinos
Copy link
Contributor

scinos commented May 20, 2020

Changes by @scinos:

  • Undo automatic dedupe yarn.lock to avoid upgrading other packages.

@scinos scinos changed the base branch from master to update/bump-libraries May 22, 2020 06:37
@scinos scinos merged commit 95beb9c into update/bump-libraries May 22, 2020
@scinos scinos deleted the renovate/eslint-7.x branch May 22, 2020 06:38
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 22, 2020
@scinos scinos mentioned this pull request May 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scinos scinos

Labels
Framework [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matticbot @scinos @renovate-bot