Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Update TXT record error to be clearer #42721

Merged
merged 2 commits into from
May 28, 2020

Conversation

eltongo
Copy link
Contributor

@eltongo eltongo commented May 27, 2020

Changes proposed in this Pull Request

This PR updates the error shown when a user tries to enter a TXT record that is longer than 255 characters.

Testing instructions

Try to add a TXT record with a value longer than 255 characters to your domain. You should see the following error:

Screenshot 2020-05-27 at 7 49 08 PM

You should see a similar error as well when the TXT record is empty.

@eltongo eltongo added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels May 27, 2020
@eltongo eltongo requested a review from a team May 27, 2020 17:50
@eltongo eltongo self-assigned this May 27, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented May 27, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~108 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains       +200 B  (+0.0%)     +108 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@eltongo eltongo merged commit 9fee3dc into master May 28, 2020
@eltongo eltongo deleted the update/txt-record-length-error branch May 28, 2020 13:52
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 28, 2020
@a8ci18n
Copy link

a8ci18n commented May 28, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3695673

Thank you @eltongo for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 1, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants