-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checkout: update initial view of review step (3) #42866
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~185 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
46f9f42
to
2139dfd
Compare
This was only used for some computational CSS that was being overwritten in the same rule and could be achieved with a :last-of-type selector.
This is leftover from when the first step was the Payment Method step. Adding a coupon happened in the final step, and could require more information from the payment method step. It doesn't break anything currently, but could be buggy in the future.
2139dfd
to
fe164db
Compare
One thing I noticed:
|
Looking good! I made some minor edits to the font sizes and spacing around the coupon. Not blocking for merging but I wanted to change the review order step title while you're in edit mode but couldn't figure out how to bring the isSummary state up to that level. One last note, I can confirm the issue with the Edit that Payton mentioned. |
Thanks for catching the editing issue - it's much more apparent now that the contact details step might be marked as complete when the cart loads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me!
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3750387 Thank you @michaeldcain for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
In #42678, the "Order Review" step was pulled out of the step flow for Checkout and made persistent. This PR introduces a default summary view of that step to make the already-completed information easier to scan.
Summary mode (default):
![summary](https://user-images.githubusercontent.com/942359/83570048-67944580-a4f3-11ea-8d10-d119ca0f7a0e.png)
Edit mode:
![edit](https://user-images.githubusercontent.com/942359/83570084-7549cb00-a4f3-11ea-9f53-161f38287331.png)
As part of the PR, I needed to make the following changes to the composite checkout package:
CheckoutStepBody
wherever possible.CheckoutStep(s)
act as a wrapper forCheckoutStepBody
and handle mechanics of progressing through steps.areStepsActive
prop toCheckoutSteps
to allow for the entire set of steps to be inactive when another element of Checkout is focused.To Test:
?flags=composite-checkout-force
and complete steps, return to edit your order, make sure that Checkout progress is maintained… your journey awaits.