-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial data layer and data query component for /all-domains
endpoint
#42930
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~557 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
a2b6f1f
to
9e0f1c6
Compare
/all-domains
endpoint
/all-domains
endpoint/all-domains
endpoint
76b7ea0
to
d80f31d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, tested it and the state is populated correctly. Left a small comment but we can fix it in a follow up PR
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3763827 Hi @olaseni, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
/all-domains
.QueryAllDomains
to manage fetching domains data.Testing instructions
allDomains
exists in the tree.