Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial data layer and data query component for /all-domains endpoint #42930

Merged
merged 8 commits into from
Jun 5, 2020

Conversation

olaseni
Copy link
Contributor

@olaseni olaseni commented Jun 3, 2020

Changes proposed in this Pull Request

  • Gets domains data from a new HTTP path i.e. /all-domains.
  • A new data component QueryAllDomains to manage fetching domains data.

Testing instructions

@olaseni olaseni self-assigned this Jun 3, 2020
@matticbot
Copy link
Contributor

@olaseni olaseni marked this pull request as draft June 3, 2020 10:32
@matticbot
Copy link
Contributor

matticbot commented Jun 3, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~557 bytes added 📈 [gzipped])

name     parsed_size           gzip_size
domains      +1880 B  (+0.2%)     +557 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@olaseni olaseni force-pushed the add/domains-all-domains-data-layer branch from a2b6f1f to 9e0f1c6 Compare June 3, 2020 12:29
@olaseni olaseni changed the title WIP: Initial data layer for all domains WIP: Initial data layer and data query component for /all-domains endpoint Jun 4, 2020
@olaseni olaseni marked this pull request as ready for review June 4, 2020 13:56
@olaseni olaseni requested a review from a team June 4, 2020 13:56
@olaseni olaseni added [Feature Group] Emails & Domains Features related to email integrations and domain management. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 4, 2020
@olaseni olaseni changed the title WIP: Initial data layer and data query component for /all-domains endpoint Initial data layer and data query component for /all-domains endpoint Jun 4, 2020
@olaseni olaseni force-pushed the add/domains-all-domains-data-layer branch from 76b7ea0 to d80f31d Compare June 5, 2020 11:04
Copy link
Contributor

@hambai hambai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, tested it and the state is populated correctly. Left a small comment but we can fix it in a follow up PR

@olaseni olaseni merged commit 528a204 into master Jun 5, 2020
@olaseni olaseni deleted the add/domains-all-domains-data-layer branch June 5, 2020 12:56
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 5, 2020
@a8ci18n
Copy link

a8ci18n commented Jun 5, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3763827

Hi @olaseni, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Failed to retrieve all domains

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Jun 11, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants