New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composite-checkout: Clarify label for full credit payment method #43063
composite-checkout: Clarify label for full credit payment method #43063
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~36 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
@@ -148,8 +148,9 @@ export function WordPressCreditsLabel( { credits } ) { | |||
return ( | |||
<React.Fragment> | |||
<div> | |||
{ translate( 'WordPress.com Credits: %(amount)s', { | |||
{ translate( 'WordPress.com Credits: %(amount)s available', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ I love it.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3784269 Thank you @nbloomf for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
At the moment it's easy to misunderstand the full credits payment method as changing the product price or using all credits on the account.
Testing instructions
Enter checkout with enough credits to cover the purchase (to trigger the full credits payment method) and inspect the label: