Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composite-checkout: Clarify label for full credit payment method #43063

Merged
merged 1 commit into from Jun 8, 2020

Conversation

nbloomf
Copy link
Contributor

@nbloomf nbloomf commented Jun 8, 2020

Changes proposed in this Pull Request

  • Change the label on the full credits payment method from "WordPress.com Credits: X" to "WordPress.com Credits: X available", to help clarify what that number means.

At the moment it's easy to misunderstand the full credits payment method as changing the product price or using all credits on the account.

Testing instructions

Enter checkout with enough credits to cover the purchase (to trigger the full credits payment method) and inspect the label:

Screen Shot 2020-06-08 at 8 36 24 AM

@nbloomf nbloomf added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jun 8, 2020
@nbloomf nbloomf requested a review from sirbrillig June 8, 2020 13:41
@nbloomf nbloomf self-assigned this Jun 8, 2020
@matticbot
Copy link
Contributor

@nbloomf nbloomf added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Jun 8, 2020
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~36 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout        +69 B  (+0.0%)      +36 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@@ -148,8 +148,9 @@ export function WordPressCreditsLabel( { credits } ) {
return (
<React.Fragment>
<div>
{ translate( 'WordPress.com Credits: %(amount)s', {
{ translate( 'WordPress.com Credits: %(amount)s available', {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This change will be queued for retranslation. We'll display the English text until then.

Copy link
Member

@sirbrillig sirbrillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ I love it.

@nbloomf nbloomf added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 8, 2020
@nbloomf nbloomf merged commit 5ad595d into master Jun 8, 2020
@nbloomf nbloomf deleted the update/full-credits-label-in-composite-checkout branch June 8, 2020 15:29
@a8ci18n
Copy link

a8ci18n commented Jun 8, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3784269

Thank you @nbloomf for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Jun 17, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants