Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch up to 2000 list items, refactor list edit components #43229

Merged
merged 7 commits into from
Nov 2, 2020

Conversation

blowery
Copy link
Contributor

@blowery blowery commented Jun 12, 2020

Changes proposed in this Pull Request

  • Fetch up to 2000 list items in the initial pass
  • Refactor the list edit components into functional components and add a loading indicator for the list items
  • Always show the export tab, disable the button if we have not loaded the list items yet

Testing instructions

  • Load a list with more than 10 items. Verify that all 10 items appear.
  • Verify that a loading indicator appears on the /items section while loading the items
  • Verify the export tab appears instantly along with the Sites and Details tabs
  • Load the export tab directly on a long list and a slow network. Verify that the button is disabled while the list items load and enabled once loaded if there are items in the list.

@blowery blowery added this to the Reader List Management milestone Jun 12, 2020
@blowery blowery requested a review from a team as a code owner June 12, 2020 14:16
@blowery blowery self-assigned this Jun 12, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jun 12, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~219 bytes added 📈 [gzipped])

name                                        parsed_size           gzip_size
async-load-calypso-reader-list-manage           +1224 B  (+4.4%)     +189 B  (+2.5%)
async-load-calypso-reader-sidebar                -357 B  (-0.6%)      -75 B  (-0.5%)
async-load-design-blocks                         +200 B  (+0.0%)      +48 B  (+0.0%)
async-load-calypso-reader-following-manage       +200 B  (+0.2%)      +42 B  (+0.1%)
async-load-calypso-reader-list-stream            +122 B  (+0.9%)      +15 B  (+0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@jsnmoon jsnmoon added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature] Reader The reader site on Calypso. labels Jun 12, 2020
Copy link
Member

@jsnmoon jsnmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described.

It would be nice to add a loading indicator to the export page in the future while ListItems are being loaded.

@blowery
Copy link
Contributor Author

blowery commented Jun 13, 2020

@jsnmoon

It would be nice to add a loading indicator to the export page in the future while ListItems are being loaded.

done

also added missing list detection and translations

@bluefuton bluefuton added [Status] Needs Rebase and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 15, 2020
@bluefuton bluefuton merged commit 013709e into master Nov 2, 2020
@bluefuton bluefuton deleted the update/fetch-more-list-items branch November 2, 2020 01:15
@a8ci18n
Copy link

a8ci18n commented Nov 2, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/5094392

Hi @blowery, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • DANGER!!
  • DELETE LIST FOREVER

Thank you in advance!

@a8ci18n
Copy link

a8ci18n commented Nov 3, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Reader The reader site on Calypso.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants