New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
composite-checkout: Add error boundary around top level (1) #43268
composite-checkout: Add error boundary around top level (1) #43268
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~83 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the import fixed, this works as expected. The correct message appears on both the page and in the logs. Let's watch the logs after this merges, it might be nice to make the message more helpful for the user if we see a number of these.
Co-authored-by: Michael Cain <cain@automattic.com>
Thanks! I clearly didn't have time to test this last night. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works as described. LGTM.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/3848930 Hi @sirbrillig, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include this string: Thank you in advance! |
Translation for this Pull Request has now been finished. |
Changes proposed in this Pull Request
This adds a React error boundary around the entire component tree of composite checkout starting at
CheckoutSystemDecider
. Hopefully this will never be hit because composite checkout already has several layers of error boundaries withinCheckoutProvider
but it will give us the opportunity to:Testing instructions
CompositeCheckout
component itself.composite checkout load error
get a new entry.