i18n: Don't rewrite blog post URLs

[akirk]

The “Learn More” link on the Jetpack > Activity Log page 404’s when using a language that has a language WordPress.com blog.

Fails: https://wordpress.com/es/blog/2018/10/30/introducing-activity/

Works: https://wordpress.com/blog/2018/10/30/introducing-activity/

props for discovering @cathymcbride

Changes proposed in this Pull Request

• localizeUrl() should not rewrite blog post URLs since we don't have all posts translated and currently no english-slug redirects in place.

Testing instructions

• Covered by unit tests: yarn run test-client lib/i18n-utils
• Verify that the link above always links to the English blog post, no matter which language.

[matticbot]

Test live: https://calypso.live/?branch=update/localize-url-ignore-blog-posts

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~246 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-main                  +166 B  (+0.0%)      +62 B  (+0.0%)
entry-login                 +166 B  (+0.0%)      +64 B  (+0.0%)
entry-gutenboarding         +166 B  (+0.0%)      +56 B  (+0.0%)
entry-domains-landing       +166 B  (+0.0%)      +64 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[yuliyan]

Tested, works fine!

[yuliyan]

Nitpick: I'd use limitPathMatch.test( urlParts.pathname ) as it's a better fit in this use case (also has better performance, even though it probably won't be noticeable here).

[akirk]

Thanks! Changed it.

[yuliyan]

limitPathMatch.test( urlParts.pathname ) - same as above