Analytics: Remove problematic "blacklist"/"whitelist" language #43395 #43643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
sarayourfriend
changed the title
sarayourfriend
added
the
[Status] Needs Review
sarayourfriend
added
the
[Feature] Tracks Metrics & Monitoring
sarayourfriend
requested review from
sgomes,
MicBosi and
jsnmoon
and removed request for
sgomes
sgomes
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
LGTM, thanks @saramarcondes! The changes look good and it tests well 👍
This seems to be based on a version of the base branch that had a linking issue, which only surfaced as a warning and not an error. That's since been fixed, and I would recommend rebasing before merging; I tested that and it seems to work correctly, in any case.
Also, added a minor comment below.
| */ | ||
| import debug from './debug'; | ||
|
|
||
| // For better load performance, these routes are exluded from loading ads. |
sarayourfriend
force-pushed
the
update/remove-problematic-language-whitelist-blacklist-analytics
branch
from
c608902
to
9297672
Compare
|
@sgomes Thanks for the review and the heads up. I've rebased and corrected the misspelling 😊 |
sarayourfriend
deleted the
update/remove-problematic-language-whitelist-blacklist-analytics
branch
matticbot
removed
the
[Status] Needs Review
sarayourfriend
added a commit
that referenced
this pull request
Jun 29, 2020
sarayourfriend
added a commit
that referenced
this pull request
Jun 29, 2020
sarayourfriend
added a commit
that referenced
this pull request
Jun 29, 2020
sarayourfriend
added a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
isUrlBlacklistedForPerformancetoisUrlExcludedForPerformanceTesting instructions
ad-trackingconfig, and give GDPR consent. Then navigate to a page that is excluded from analytics (/log-in) and verify that analytics are blocked by checkingisAdTrackingAllowedin the browser console and verifying it isfalse.Addresses part of #43395