-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics: Remove problematic "blacklist"/"whitelist" language #43395 #43643
Analytics: Remove problematic "blacklist"/"whitelist" language #43395 #43643
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @saramarcondes! The changes look good and it tests well 👍
This seems to be based on a version of the base branch that had a linking issue, which only surfaced as a warning and not an error. That's since been fixed, and I would recommend rebasing before merging; I tested that and it seems to work correctly, in any case.
Also, added a minor comment below.
*/ | ||
import debug from './debug'; | ||
|
||
// For better load performance, these routes are exluded from loading ads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/exluded/excluded/
c608902
to
9297672
Compare
@sgomes Thanks for the review and the heads up. I've rebased and corrected the misspelling 😊 |
Changes proposed in this Pull Request
isUrlBlacklistedForPerformance
toisUrlExcludedForPerformance
Testing instructions
ad-tracking
config, and give GDPR consent. Then navigate to a page that is excluded from analytics (/log-in
) and verify that analytics are blocked by checkingisAdTrackingAllowed
in the browser console and verifying it isfalse
.Addresses part of #43395