Jetpack Connect: Remove problematic "blacklist"/"whitelist" language #43395

[sarayourfriend]

Changes proposed in this Pull Request

• Rename SITE_BLACKLISTED to SITE_BLOCKED
• Rename isSiteBlacklistedError to isSiteBlockedError
• Rename MOBILE_APP_REDIRECT_URL_WHITELIST to ALLOWED_MOBILE_APP_REDIRECT_URL_LIST

Testing instructions

• Ensure blocked sites still behave as expected (are not allowed to connect to Jetpack, etc).

Addresses part of #43395

[matticbot]

Test live: https://calypso.live/?branch=update/remove-problematic-language-whitelist-blacklist-jetpack-connect

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~3 bytes removed 📉 [gzipped])

name             parsed_size           gzip_size
jetpack-connect        -28 B  (-0.0%)       -3 B  (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[sarayourfriend]

@sirreal Pinging you as I think the actual person who originally worked on this was Marin but he's still on parental leave. Any chance you could review this or suggest someone else if you're not able?

[wp-desktop]

WordPress Desktop CI Failure (ci/wp-desktop): @saramarcondes please re-try this workflow ("Rerun Workflow from Failed") and/or review this PR for breaking changes. Please also ensure this branch is rebased off latest Calypso master.

[nsakaimbo]

👋 Seeing this error in the source build for wp-desktop (link) - under "Build sources":

ERROR in ./jetpack-connect/jetpack-connection.jsx 167:17-33
 
"export 'SITE_BLACKLISTED' was not found in './connection-notice-types'

[sarayourfriend]

Thanks @nsakaimbo, changes are up 👍

ci/wp-desktop passing, closing review

[sirreal]

I gave this a visual inspection and everything makes sense. I did a few searches and the renames seem to be good. Thanks!

[AnnaMag]

@saramarcondes, thumbs up that I get an error message in the error message itself also.