-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Connect: Remove problematic "blacklist"/"whitelist" language #43395 #43647
Jetpack Connect: Remove problematic "blacklist"/"whitelist" language #43395 #43647
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~3 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
1f6f3e5
to
0e350c8
Compare
@sirreal Pinging you as I think the actual person who originally worked on this was Marin but he's still on parental leave. Any chance you could review this or suggest someone else if you're not able? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WordPress Desktop CI Failure (ci/wp-desktop): @saramarcondes please re-try this workflow ("Rerun Workflow from Failed") and/or review this PR for breaking changes. Please also ensure this branch is rebased off latest Calypso master.
👋 Seeing this error in the source build for wp-desktop (link) - under "Build sources":
|
0e350c8
to
744efc2
Compare
Thanks @nsakaimbo, changes are up 👍 |
744efc2
to
945e919
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave this a visual inspection and everything makes sense. I did a few searches and the renames seem to be good. Thanks!
@saramarcondes, thumbs up that I get an error message in the error message itself also. |
Changes proposed in this Pull Request
SITE_BLACKLISTED
toSITE_BLOCKED
isSiteBlacklistedError
toisSiteBlockedError
MOBILE_APP_REDIRECT_URL_WHITELIST
toALLOWED_MOBILE_APP_REDIRECT_URL_LIST
Testing instructions
Addresses part of #43395