Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack Search: add WP.com Search purchase Thank you note #43910

Merged
merged 6 commits into from
Jul 7, 2020

Conversation

AnnaMag
Copy link
Contributor

@AnnaMag AnnaMag commented Jul 6, 2020

Changes proposed in this Pull Request

  • Adding Search specific Thank you message and redirect the Customizer to setup/try the product
  • Add tracking to match the Jetpack purchase, extending the latter with the site info.

Testing instructions

  • Purchase Jetpack Search for a WP.com at http://calypso.localhost:3000/checkout/:wpcomsite/jetpack_search_monthly
  • verify that the Thank you note is displayed with a relevant text
  • verify the redirect to the Customizer

ty

Fixes #42285

@AnnaMag AnnaMag added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Pre-launch Tasks that need to be completed before launch [Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. labels Jul 6, 2020
@AnnaMag AnnaMag requested review from gibrown and a team July 6, 2020 12:24
@AnnaMag AnnaMag self-assigned this Jul 6, 2020
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Jul 6, 2020

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~341 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
checkout      +1032 B  (+0.1%)     +337 B  (+0.1%)
plans           +15 B  (+0.0%)       +4 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@gibrown gibrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and code lgtm

@AnnaMag AnnaMag merged commit 0cc47a1 into master Jul 7, 2020
@AnnaMag AnnaMag deleted the add/wp-thank-you branch July 7, 2020 09:45
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search Jetpack Search - A feature to speed up and improve the look of Search on your site. Pre-launch Tasks that need to be completed before launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jetpack Search: add product specific Thank you modal for WP.com sites.
4 participants