New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Actions: Replace master references with origin/HEAD #43942
GitHub Actions: Replace master references with origin/HEAD #43942
Conversation
f58cbea
to
b816c55
Compare
Wow, nice! Thank you for doing this. I didn't know this was a thing :) To cause the FSE plugin tests to run, could you commit a small change to a file in |
b57fb61
to
1278e05
Compare
There's also this line in the ICFY action but it cannot be changed to use I suspect this is due to how the checkout action works which is that it inits an empty repository and then add the origin remote rather than just cloning the repository. I think this causes it to lose the mapping between From
This will just need to be changed when we actually rename the branch to |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the FSE Plugin on WordPress.com D46056-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing in the FSE Plugin for more info: PCYsg-ly5-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to the FSE plugin workflow look good to me!
95211b4
to
1278e05
Compare
In many cases,
origin
just by itself is an alias for origin/HEAD.When a specific branch name is needed, such as in the case of the
CI caches changed in this commit, we can use HEAD as a direct
alias for the primary branch, regardless of to what it is currently
set.
See
set-head
entry ingit remote
man page: https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-remote.htmlOur repository is configured with
HEAD -> master
:Changes proposed in this Pull Request
master
branch with references toorigin/HEAD
or justorigin
orHEAD
when appropriateTesting instructions
Part of #43939