Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plans: Tweak Payments feature language in the Plans feature list. #44013

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

donlair
Copy link
Contributor

@donlair donlair commented Jul 8, 2020

This PR tweaks the language that describes the Payments features in the Plans comparison section of Calypso. These changes match the current verbiage on the /pricing page of WPcom.

Before:
Screen Shot 2020-07-08 at 4 12 50 PM

After:
Screen Shot 2020-07-08 at 4 29 59 PM

And here's a picture of the new tooltip copy:
86920153-4d9fe100-c0f7-11ea-828e-5ba95a74d183

Testing instructions

  • Checkout the branch (git checkout update/plates-tweak-payments-wording)
  • Start Calypso (yarn start)
  • Navigate to /plans/:siteSlug
  • Confirm that the Payments row contains the updated copy.

@donlair donlair self-assigned this Jul 8, 2020
@matticbot
Copy link
Contributor

@donlair donlair requested a review from anneforbush July 8, 2020 20:41
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@donlair donlair added [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jul 8, 2020
getDescription: () => i18n.translate( 'Accept monthly or annual payments on your website.' ),
getTitle: () => i18n.translate( 'Payments' ),
getDescription: () =>
i18n.translate( 'Accept one-time, monthly, or annual payments on your website.' ),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 3 times:
translate( 'Accept one-time, monthly or annual payments on your website.' ) ES Score: 11
See 1 additional suggestions in the PR translation status page

@a8ci18n
Copy link

a8ci18n commented Jul 8, 2020

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4030689

Thank you @donlair for including a screenshot in the description! This is really helpful for our translators.

@donlair donlair force-pushed the update/plans-tweak-payments-wording branch from fab1612 to 6de91e4 Compare July 9, 2020 15:15
Copy link
Contributor

@victorespigares victorespigares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚢

@donlair donlair force-pushed the update/plans-tweak-payments-wording branch from 6de91e4 to 84b10eb Compare July 10, 2020 12:19
@anneforbush
Copy link

Looks good, @donlair. On Premium plans and up I noticed we have both Payments and Site Monetization showing in the features list. We can clarify that as a separate PR unless you think it makes sense to lump that in with this one.

@donlair donlair merged commit a5079f6 into master Jul 10, 2020
@donlair donlair deleted the update/plans-tweak-payments-wording branch July 10, 2020 16:47
@matticbot matticbot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] String Freeze Add the [Status] String Freeze label to your PR to ensure new strings are translated before merging labels Jul 10, 2020
@a8ci18n
Copy link

a8ci18n commented Jul 10, 2020

Translation for this Pull Request has now been finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants