-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plans: Tweak Payments feature language in the Plans feature list. #44013
Conversation
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
getDescription: () => i18n.translate( 'Accept monthly or annual payments on your website.' ), | ||
getTitle: () => i18n.translate( 'Payments' ), | ||
getDescription: () => | ||
i18n.translate( 'Accept one-time, monthly, or annual payments on your website.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ℹ️ String reuse speeds up translation and improves consistency. The following string might make a good alternative and has already been translated 3 times:
translate( 'Accept one-time, monthly or annual payments on your website.' )
ES Score: 11
See 1 additional suggestions in the PR translation status page
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/4030689 Thank you @donlair for including a screenshot in the description! This is really helpful for our translators. |
fab1612
to
6de91e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚢
6de91e4
to
84b10eb
Compare
Looks good, @donlair. On Premium plans and up I noticed we have both Payments and Site Monetization showing in the features list. We can clarify that as a separate PR unless you think it makes sense to lump that in with this one. |
Translation for this Pull Request has now been finished. |
This PR tweaks the language that describes the Payments features in the Plans comparison section of Calypso. These changes match the current verbiage on the /pricing page of WPcom.
Before:
![Screen Shot 2020-07-08 at 4 12 50 PM](https://user-images.githubusercontent.com/35781181/86967095-2ae1ec80-c138-11ea-86f4-9a3804d0382f.png)
After:
![Screen Shot 2020-07-08 at 4 29 59 PM](https://user-images.githubusercontent.com/35781181/86967301-75636900-c138-11ea-947c-ede805e8db0c.png)
And here's a picture of the new tooltip copy:
![86920153-4d9fe100-c0f7-11ea-828e-5ba95a74d183](https://user-images.githubusercontent.com/35781181/86967911-47325900-c139-11ea-82e5-cab3864fc0a4.png)
Testing instructions